Re: [PATCH 3/4] Check whether pages are poisoned before copying

Andi Kleen
2011-03-17T15:21:57Z

> At least copy to the last page of the huge page is performed after
> all preceding copies are finished. So I'm not sure it is really
> "a few" or not.
> Still I think making the window smaller than now is worthwhile,
> no matter it is change from 0.1% to 0.01%, or from 0.01% to 0.001%.

Note that hwpoison will never reach 100% coverage. That's impossible.
But to get nearer to 100% it's better to concentrate of the paths
that affect long time windows and significant amounts of memory.
What those are is often non-obvious and needs measurements.

>
> Or did you find the downside of the check here?

The usual problem is how to test it. That tends to be harder
than just writing the code. If it's not tested it's probably
not worth having.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.