From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bibek BASU <bibek.basu@stericsson.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins
Date: Thu, 17 Mar 2011 13:11:32 -0600 [thread overview]
Message-ID: <20110317191132.GA12824@angua.secretlab.ca> (raw)
In-Reply-To: <AANLkTikw87uS4w15ZWZOp8bUU1jYwn1xK4tp5cSrpeYH@mail.gmail.com>
On Tue, Mar 15, 2011 at 03:51:09PM +0100, Linus Walleij wrote:
> On Tue, Mar 15, 2011 at 3:33 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
>
> > Ping me *after* Russell's tree gets merged and I'll pick it up. I
> > don't want to mess about with apply-order breakage.
>
> This driver does not depend on anything from Russells tree
> or any other tree for that matter... It's a clean merge.
CC drivers/gpio/ab8500-gpio.o
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c: In function 'ab8500_gpio_probe':
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: 'MOP500_AB8500_VIR_GPIO_IRQ_BASE' undeclared (first use in this function)
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: (Each undeclared identifier is reported only once
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: for each function it appears in.)
make[2]: *** [drivers/gpio/ab8500-gpio.o] Error 1
make[1]: *** [drivers/gpio/ab8500-gpio.o] Error 2
make: *** [sub-make] Error 2
and:
$ git grep MOP500_AB8500_VIR_GPIO_IRQ_BASE origin
$
Looks like I cannot merge this yet.
BTW, why is this driver hardcoding the gpio irq base address instead
of retrieving it from the platform data?
g.
next prev parent reply other threads:[~2011-03-17 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 3:34 [PATCH] AB8500 GPIO : Board Support for AB8500 GPIO Driver Bibek Basu
2011-02-16 3:34 ` [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins Bibek Basu
2011-02-16 8:32 ` Linus Walleij
2011-02-28 0:19 ` Samuel Ortiz
2011-03-07 14:32 ` Linus Walleij
2011-03-14 16:37 ` Linus Walleij
2011-03-14 16:46 ` Grant Likely
2011-03-15 9:10 ` Linus Walleij
2011-03-15 14:33 ` Grant Likely
2011-03-15 14:51 ` Linus Walleij
2011-03-17 19:11 ` Grant Likely [this message]
2011-03-18 3:38 ` Bibek BASU
2011-03-18 8:29 ` Linus Walleij
2011-03-24 4:00 ` Grant Likely
2011-03-18 3:37 ` [PATCH] AB8500 GPIO : Board Support for AB8500 GPIO Driver Bibek Basu
2011-03-18 3:37 ` [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins Bibek Basu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317191132.GA12824@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=bibek.basu@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox