public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org, dzickus@redhat.com
Subject: Re: [PATCH]: SMBIOS: Add initial code and export version via sysfs
Date: Thu, 17 Mar 2011 12:22:24 -0700	[thread overview]
Message-ID: <20110317192224.GA30105@suse.de> (raw)
In-Reply-To: <4D825D32.1080309@redhat.com>

On Thu, Mar 17, 2011 at 03:12:50PM -0400, Prarit Bhargava wrote:
> 
> 
> On 03/17/2011 03:09 PM, Alan Cox wrote:
> >> +static struct class smbios_class = {
> >> +	.name = "smbios",
> >> +	.dev_release = (void(*)(struct device *)) kfree,

Wait, what?  Heh, nice try, you can't do this.  If you can, your code is
doing something really wrong.  Or hacky like trying to put the device
structure as the first thing in your structure.  If that gets moved,
this will break badly.  Don't.

> >> +};
> >>     
> > I thought the policy was no new classes- Greg ?
> >   
> 
> Greg, eventually the SMBIOS code could replace the mixed DMI/SMBIOS code
> we have right now.  If there is a "no new classes" policy, could you
> give me an idea of what I should do/use instead?  The DMI stuff is
> currently in its own class ...

Ideally you should use a bus instead.  Let me go look at your original
patch and get back to you on this...

thanks,

greg k-h

  reply	other threads:[~2011-03-17 19:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 13:57 [PATCH]: SMBIOS: Add initial code and export version via sysfs Prarit Bhargava
2011-03-17 19:09 ` Alan Cox
2011-03-17 19:12   ` Prarit Bhargava
2011-03-17 19:22     ` Greg KH [this message]
2011-03-17 19:30 ` Greg KH
2011-03-17 19:55   ` Prarit Bhargava
2011-03-17 20:07     ` Greg KH
2011-03-21 15:45       ` Prarit Bhargava
2011-03-21 16:06         ` Alan Cox
2011-03-27 22:29           ` Prarit Bhargava
2011-03-17 20:08     ` Prarit Bhargava
2011-03-17 20:15       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110317192224.GA30105@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox