Re: [GIT PATCH] STAGING patches for .39

[Greg KH <greg@kroah.com>]

On Thu, Mar 17, 2011 at 12:55:38PM -0700, Randy Dunlap wrote:
> On Wed, 16 Mar 2011 19:02:12 -0700 Greg KH wrote:
> 
> > On Wed, Mar 16, 2011 at 06:52:39PM -0700, Greg KH wrote:
> > > On Wed, Mar 16, 2011 at 05:34:08PM -0700, Linus Torvalds wrote:
> > > > On Wed, Mar 16, 2011 at 5:32 PM, Linus Torvalds
> > > > <torvalds@linux-foundation.org> wrote:
> > > > >
> > > > > The one with inifinite errors was vt6655.
> > > > 
> > > > vt6656 had same/similar issues. In fact, maybe it's simply because I
> > > > built both of them in, and get infinite "multiple definitions" because
> > > > they are the same driver with small differences?
> > > 
> > > Ah, probably, if they are both built into the kernel that might happen
> > > due to the global symbols in them.  Actually that's odd, Randy's usual
> > > 'randconfig' tester usually catches these, I'll make the Kconfig files
> > > force them to be modules to keep this from happening in the future.
> > 
> > Yes, that looks like the problem, as building them as modules in your
> > tree right now works just fine.
> > 
> > This patch below should solve your build issue, let me know if it
> > doesn't.
> 
> Thanks for the patch.  You had suggested 1-2 months ago that someone do
> this, so I was waiting to see if someone would actually do it.

Ah, sorry about that, I forgot about it.

> I was hoping that a staging developer would do it (not the staging
> maintainer).

Heh, well, these drivers are just "placeholders" as the "real" in-kernel
drivers are being developed for this hardware, so I don't expect to see
much, if any development happening on them.

thanks,

greg k-h