* [patch 2/2] efivars: handle errors from register_efivars()
@ 2011-03-18 7:12 Dan Carpenter
2011-03-18 9:24 ` Mike Waychison
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-18 7:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Mike Waychison, Chris Wright, Tejun Heo, linux-kernel,
kernel-janitors
We should unwind and return an error if register_efivars() fails.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index ff2fe40..5d1ec68 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -803,6 +803,8 @@ efivars_init(void)
ops.set_variable = efi.set_variable;
ops.get_next_variable = efi.get_next_variable;
error = register_efivars(&__efivars, &ops, efi_kobj);
+ if (error)
+ goto err_put;
/* Don't forget the systab entry */
error = sysfs_create_group(efi_kobj, &efi_subsys_attr_group);
@@ -810,10 +812,15 @@ efivars_init(void)
printk(KERN_ERR
"efivars: Sysfs attribute export failed with error %d.\n",
error);
- unregister_efivars(&__efivars);
- kobject_put(efi_kobj);
+ goto err_unregister;
}
+ return 0;
+
+err_unregister:
+ unregister_efivars(&__efivars);
+err_put:
+ kobject_put(efi_kobj);
return error;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2] efivars: handle errors from register_efivars()
2011-03-18 7:12 [patch 2/2] efivars: handle errors from register_efivars() Dan Carpenter
@ 2011-03-18 9:24 ` Mike Waychison
0 siblings, 0 replies; 2+ messages in thread
From: Mike Waychison @ 2011-03-18 9:24 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman, Mike Waychison, Chris Wright,
Tejun Heo, linux-kernel, kernel-janitors
On Fri, Mar 18, 2011 at 12:12 AM, Dan Carpenter <error27@gmail.com> wrote:
> We should unwind and return an error if register_efivars() fails.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mike Waychison <mikew@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-18 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-18 7:12 [patch 2/2] efivars: handle errors from register_efivars() Dan Carpenter
2011-03-18 9:24 ` Mike Waychison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox