Re: [PATCH] uio_netx: Add support for netPLC cards

["Hans J. Koch" <hjk@hansjkoch.de>]

On Fri, Mar 18, 2011 at 05:23:35PM -0700, Greg KH wrote:
> On Sat, Mar 19, 2011 at 01:12:11AM +0100, Hans J. Koch wrote:
> > On Thu, Mar 17, 2011 at 11:40:59AM +0000, Daniel Trautmann wrote:
> > > This patch adds support for Hilscher / IBHsoftec netPLC cards to uio_netx userspace IO driver.
> > > 
> > > Signed-off-by: Daniel Trautmann <dtrautmann@ibhsoftec-sps.de>
> > > ---
> > >  drivers/uio/uio_netx.c |   19 +++++++++++++++++++
> > >  1 files changed, 19 insertions(+), 0 deletions(-)
> > 
> > Against what kernel is that supposed to apply? It doesn't apply against
> > Linus' current tree here.
> > 
> > And, please, run your patch through scripts/checkpatch.pl before posting it.
> > 
> > I get:
> > -----------------------
> > total: 15 errors, 16 warnings, 37 lines checked
> > 
> > NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
> >       scripts/cleanfile
> > -----------------------
> > I find 15 errors in 19 insertions a bit too much. Most of it is whitespace,
> > so it might be a problem with your mail client. Please check.
> > 
> > > 
> > > diff --git a/drivers/uio/uio_netx.c b/drivers/uio/uio_netx.c
> > > index 5ffdb48..7921190 100644
> > > --- a/drivers/uio/uio_netx.c
> > > +++ b/drivers/uio/uio_netx.c
> > > @@ -18,6 +18,9 @@
> > >  
> > >  #define PCI_VENDOR_ID_HILSCHER         0x15CF
> > >  #define PCI_DEVICE_ID_HILSCHER_NETX    0x0000
> > > +#define PCI_DEVICE_ID_HILSCHER_NETPLC  0x0010
> > 
> > Hmpf, yes... The three defines above should go to include/linux/pci_ids.h
> 
> No, read the top of that file please.  They belong here.

Ooops, yes.

> 
> > I should have done that from the beginning, could you fix it now?
> 
> Please don't.

Now I remember why I once put them here :)

Thanks,
Hans