* [patch] vlynq: fix resource size calculation
@ 2011-03-19 4:38 Dan Carpenter
2011-03-21 12:25 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-19 4:38 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, kernel-janitors
The original code had an off-by-one error so we didn't release the
entire memory region on remove().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index f885c86..1d37553 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
device_unregister(&dev->dev);
iounmap(dev->local);
- release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+ release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
kfree(dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] vlynq: fix resource size calculation
2011-03-19 4:38 [patch] vlynq: fix resource size calculation Dan Carpenter
@ 2011-03-21 12:25 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2011-03-21 12:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On Saturday 19 March 2011 05:38:13 Dan Carpenter wrote:
> The original code had an off-by-one error so we didn't release the
> entire memory region on remove().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index f885c86..1d37553 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -764,7 +764,7 @@ static int vlynq_remove(struct platform_device *pdev)
>
> device_unregister(&dev->dev);
> iounmap(dev->local);
> - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> + release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start + 1);
>
> kfree(dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-21 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-19 4:38 [patch] vlynq: fix resource size calculation Dan Carpenter
2011-03-21 12:25 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).