linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lina Lu" <lulina_nuaa@foxmail.com>
To: "Vivek Goyal" <vgoyal@redhat.com>
Cc: "linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: cfq-iosched.c: panic in cfq_dispatch_requests
Date: Sun, 20 Mar 2011 15:23:23 +0800	[thread overview]
Message-ID: <201103201523220468314@foxmail.com> (raw)

Hi Vivek,

I did some test with blkio weight policy these days. The kernel panic 
once in a while. 
	
>From the calltrace, It 's in func cfq_dispatch_requests(+0x058D).
And I caught a divide by zero error with system monitor tools.
	
The panic happens when I first set 100 weight to two IO pids, then 
change the weight to 200, and begin to perform IO. The kernel panic
accurately when the IO begin.

I try to find the divide 0 code in cfq_dispatch_requests. This function
call the cfq_select_queue to select a queue, and cfq_select_queue
call cfq_choose_cfqg, then choose_service_tree(). There is a expression
of division in choose_service_tree.
	
        slice = group_slice * count /
                max_t(unsigned, cfqg->busy_queues_avg[cfqd->serving_prio],
                      cfq_group_busy_queues_wl(cfqd->serving_prio, cfqd, cfqg));

I don't know whether this code divide 0. Can you take a look of this issue?

Thanks
Lina 




             reply	other threads:[~2011-03-20  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-20  7:23 Lina Lu [this message]
2011-03-21 14:07 ` cfq-iosched.c: panic in cfq_dispatch_requests Vivek Goyal
2011-03-22 15:32 ` Lina Lu
2011-03-22 15:39   ` Vivek Goyal
2011-03-22 15:48   ` Lina Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103201523220468314@foxmail.com \
    --to=lulina_nuaa@foxmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).