Re: [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT_ORIENTATION

Benjamin Tissoires
2011-03-21T13:32:21Z

Hi Henrik,

On Mon, Mar 21, 2011 at 10:02, Henrik Rydberg <rydberg@euromail.se> wrote:
> On Fri, Mar 18, 2011 at 02:27:55PM +0100, Benjamin Tissoires wrote:
>> No semantic changes, it's just easier to read the code.
>
> Please augment this commit message.

How about:

"The way the input_set_abs_params was called for the new composite
field ABS_MT_ORIENTATION was not very clear at second reading.
We can remove the non-necessary call to set_abs and use the simple
call to input_set_abs_params."

Cheers,
Benjamin

>
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
>> Reviewed-by: Stéphane Chatty <chatty@enac.fr>
>> ---
>
> Thanks,
> Henrik
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>