public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Stephane Chatty <chatty@lii-enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch
Date: Mon, 21 Mar 2011 20:06:07 +0100	[thread overview]
Message-ID: <20110321190606.GA1792@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTinAPFnHA=MWbb=Yu7U0AXrxHv2-95M=OequsAL7@mail.gmail.com>

Hi Benjamin,

> I tested it against 3M1968. I'll try to have it again to make more testing.
> What symptoms do you have?

With the modification below, it works as expected, and you can add

    Reviewed-and-tested-by: Henrik Rydberg <rydberg@euromail.se>

Thanks!

Henrik

---

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 7684e96..0f5b89f 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -424,6 +424,8 @@ static int mt_event(struct hid_device *hid, struct hid_field *field,
 			break;
 
 		default:
+			if (td->last_field_index && field->index == td->last_field_index)
+				break;
 			/* fallback to the generic hidinput handling */
 			return 0;
 		}


  parent reply	other threads:[~2011-03-21 19:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 13:27 [PATCH 0/5] Migrations to hid-multitouch, round 3 Benjamin Tissoires
2011-03-18 13:27 ` [PATCH v3 1/5] hid-multitouch: Auto detection of maxcontacts Benjamin Tissoires
2011-03-21  8:47   ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 2/5] hid-multitouch: migrate support for Stantum panels to the unified driver Benjamin Tissoires
2011-03-21  8:49   ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 3/5] hid-multitouch: migrate Cando dual touch panels to hid-multitouch Benjamin Tissoires
2011-03-21  8:50   ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 4/5] hid-multitouch: refactor initialization of ABS_MT_ORIENTATION Benjamin Tissoires
2011-03-21  9:02   ` Henrik Rydberg
2011-03-21 13:32     ` Benjamin Tissoires
2011-03-21 13:50       ` Henrik Rydberg
2011-03-18 13:27 ` [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch Benjamin Tissoires
2011-03-21  9:05   ` Henrik Rydberg
2011-03-21 10:13     ` Benjamin Tissoires
2011-03-21 10:34       ` Henrik Rydberg
2011-03-21 19:06       ` Henrik Rydberg [this message]
2011-03-21 19:56         ` Benjamin Tissoires
2011-03-22 16:34           ` [PATCH v4] " Benjamin Tissoires
2011-03-22 16:58             ` Henrik Rydberg
2011-03-24 11:46               ` Jiri Kosina
2011-03-21 16:09 ` [PATCH 0/5] Migrations to hid-multitouch, round 3 Jiri Kosina
2011-03-21 18:22   ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110321190606.GA1792@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox