Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens to hid-multitouch

Henrik Rydberg
2011-03-21T09:02:05Z

Hi Benjamin,

On Fri, Mar 18, 2011 at 02:27:56PM +0100, Benjamin Tissoires wrote:
> This patch merges the hid-3m-pct driver into hid-multitouch.
> To keep devices working the same way they used to with hid-3m-pct,
> we need to add two signal/noise ratios for width and height.
> We also need to work on width/height to send proper
> ABS_MT_ORIENTATION flag.
>
> Importing 3M into hid-multitouch also solved the bug in which
> devices handling width and height in their report descriptors
> did not show ABS_MT_TOUCH_MAJOR and ABS_MT_TOUCH_MINOR.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> Reviewed-by: Stéphane Chatty <chatty@enac.fr>
> ---

The patch _looks_ good, but I have problems getting this to work on a
3M2256. What devices were this one tested on so far?

Henrik