From: Andy Whitcroft <apw@canonical.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: checkpatch.pl: never finishes w/ specific file
Date: Mon, 21 Mar 2011 23:46:29 +0000 [thread overview]
Message-ID: <20110321234629.GA5939@localhost> (raw)
In-Reply-To: <201103211142.11317.toralf.foerster@gmx.de>
On Mon, Mar 21, 2011 at 11:42:10AM +0100, Toralf Förster wrote:
>
> Andy Whitcroft wrote at 12:47:52
> > Could you try your file with the one below and let me know:
> >
> >
> > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
>
> I've a question about line 1365 :
> if ($realfile =~ m@^include/asm\/@) {
>
> IMO either both "/" or none needs to be escaped, or ?
None as we are using '@' as the separator, however the extra \ is
benign.
-apw
prev parent reply other threads:[~2011-03-21 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:31 checkpatch.pl: never finishes w/ specific file Toralf Förster
2011-03-04 4:07 ` Jovi Zhang
2011-03-16 11:47 ` Andy Whitcroft
2011-03-16 12:16 ` Toralf Förster
2011-03-21 10:42 ` Toralf Förster
2011-03-21 23:46 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321234629.GA5939@localhost \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox