From: Oliver Neukum <oneukum@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Toby Gray <toby.gray@realvnc.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: Prevent data loss when filling tty buffer.
Date: Tue, 22 Mar 2011 09:07:42 +0100 [thread overview]
Message-ID: <201103220907.42552.oneukum@suse.de> (raw)
In-Reply-To: <20110321165612.0f764046@lxorguk.ukuu.org.uk>
Am Montag, 21. März 2011, 17:56:12 schrieb Alan Cox:
> On Mon, 21 Mar 2011 15:52:25 +0000
> Toby Gray <toby.gray@realvnc.com> wrote:
>
> > When sending large quantities of data through a CDC ACM channel it is possible
> > for data to be lost when attempting to copy the data to the tty buffer. This
> > occurs due to the return value from tty_insert_flip_string not being checked.
>
> For a tty that is normally the right thing to do - no flow control was
> asserted and the internal 64K of buffering was overrun so discard.
But should we really randomly discard a part of a buffer?
If this happens the better alternative approach would be to nuke all buffers
we currently have.
Regards
Oliver
next prev parent reply other threads:[~2011-03-22 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 15:52 [PATCH] USB: cdc-acm: Prevent data loss when filling tty buffer Toby Gray
2011-03-21 16:56 ` Alan Cox
2011-03-21 17:58 ` Toby Gray
2011-03-22 8:07 ` Oliver Neukum [this message]
2011-03-22 11:07 ` Alan Cox
2011-03-21 18:04 ` [PATCH v2] " Toby Gray
2011-03-22 10:05 ` Johan Hovold
2011-03-22 10:35 ` Alan Cox
2011-03-22 11:34 ` Johan Hovold
2011-03-22 14:11 ` Toby Gray
2011-03-22 18:05 ` Alan Cox
2011-03-22 7:43 ` [PATCH] " Oliver Neukum
2011-03-23 12:15 ` Toby Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103220907.42552.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=toby.gray@realvnc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox