From: Greg KH <gregkh@suse.de>
To: Alan Cox <alan@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Oren Weil <oren.jer.weil@intel.com>,
linux-kernel@vger.kernel.org, david@woodhou.se
Subject: Re: [PATCH 1/7] char/mei: PCI device and char driver support.
Date: Tue, 22 Mar 2011 15:22:59 -0700 [thread overview]
Message-ID: <20110322222259.GA26362@suse.de> (raw)
In-Reply-To: <20110322215759.2d982e06@bob.linux.org.uk>
On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > * In the PCI probe function, create a misc character device for
> > every instance you find behind each device. Remove the global
> > variables and constants.
>
> The current code is complex and could be a ton simpler *but* don't
> abuse misc devices when you have one per PCI instance please.
The code specifically says it only supports one device in the system at
a time. Since it can't do any more than that, why wouldn't it be
correct for a misdevice to be used here?
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-22 22:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 10:51 [PATCH 0/7] char/mei: Intel MEI Driver Oren Weil
2011-03-22 10:51 ` [PATCH 1/7] char/mei: PCI device and char driver support Oren Weil
2011-03-22 17:22 ` Arnd Bergmann
2011-03-22 21:57 ` Alan Cox
2011-03-22 22:22 ` Greg KH [this message]
2011-03-22 23:04 ` Alan Cox
2011-03-23 7:59 ` Arnd Bergmann
2011-03-22 10:51 ` [PATCH 2/7] char/mei: Interrupt handling Oren Weil
2011-03-22 10:51 ` [PATCH 3/7] char/mei: MEI "Link" layer code - MEI Hardware communications Oren Weil
2011-03-22 10:51 ` [PATCH 4/7] char/mei: MEI driver init flow Oren Weil
2011-03-22 10:51 ` [PATCH 5/7] char/mei: Hardware and MEI driver internal struct definition Oren Weil
2011-03-22 10:51 ` [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct) Oren Weil
2011-03-22 16:26 ` Greg KH
2011-03-22 16:41 ` Arnd Bergmann
2011-03-22 10:51 ` [PATCH 7/7] char/mei: Updates to char/Kconfig ane char/Makefile Oren Weil
2011-03-23 21:43 ` Valdis.Kletnieks
2011-03-22 16:23 ` [PATCH 0/7] char/mei: Intel MEI Driver Greg KH
2011-03-23 12:25 ` Weil, Oren jer
2011-03-23 13:50 ` Greg KH
2011-03-22 16:50 ` Arnd Bergmann
2011-03-23 7:20 ` Weil, Oren jer
2011-03-23 13:51 ` Greg KH
2011-03-23 15:55 ` Weil, Oren jer
2011-03-23 16:06 ` Greg KH
2011-03-23 16:20 ` Arnd Bergmann
2011-03-24 12:54 ` Weil, Oren jer
2011-03-24 13:10 ` Arnd Bergmann
2011-04-04 15:54 ` Pavel Machek
2011-04-05 6:01 ` Weil, Oren jer
2011-04-18 13:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322222259.GA26362@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox