Re: RFC: Platform data for onboard USB assets

Nicolas Pitre
2011-03-23T15:38:13Z

On Wed, 23 Mar 2011, Greg KH wrote:

> On Wed, Mar 23, 2011 at 10:53:35AM +0000, Mark Brown wrote:
> > In the specific case of MACs and device names for network adaptors we
> > have userspace solutions which are obscuring the discussion but there
> > are other things which get configured this way which one would usually
> > expect to be handled in kernel.
>
> No, this isn't obsucuring the discussion, it's exactly the point here.
>
> I asked for concrete examples of a need for this type of thing (i.e.
> platform data on USB devices), and this was the only need cited. I
> then pointed out that this is correctly solved in userspace, as it has
> for other devices like this, and that it's not a valid example of this
> need.

It was also pointed out that, unlike those examples for which the user
space solution has been developed to deal with other devices not exactly
like this, that in this case determining the specific instance of the
device that require a quirk is extremely cumbersome, hackish, fragile,
and way more ugly and complex to maintain than some in-kernel solution
where the actual knowledge of the specific board and device instance is
obvious. Again we're not after some particular customization for this
particular board, but rather after a way to make the kernel behavior
uniform across similar platforms. From that point people are still free
to use udev to apply customizations over the kernel default as they see
fit. It is that kernel default that we want to get.

> So again, this problem, for this device, has been solved in userspace
> without any kernel changes needed.

No it has not. We are not going to convince every distributions to
start accumulating complex and fragile user space hacks into their udev
rules which would be justifiably seen as unneeded cruft for exceptional
cases when the kernel can make things look regular and uniform to user
space with much less code and infrastructure. And so far it seems that
everyone else agrees with dealing with such issues in the kernel, while
the actual implementation is still debated.

Nicolas