Re: RFC: Platform data for onboard USB assets

Greg KH
2011-03-17T22:54:33Z

On Thu, Mar 17, 2011 at 11:33:01PM +0100, Arnd Bergmann wrote:
> On Thursday 17 March 2011 22:47:36 Greg KH wrote:
> > > > Patches to fix this, for this specific PandaBoard controller are gladly
> > > > accepted. What's odd is this is explicitly a Linux development board,
> > > > so you would think that this could have been caught, and fixed, in the
> > > > hardware a long time ago, right?
> > >
> > > The way everyone resolves this stuff is by patching their kernel
> > > locally.
> >
> > Well, that means that the device tree work is going to be useful here,
> > right? :)
>
> I like the idea. Let's make this the first use case where a lot of
> people will want to have the device tree on ARM. The patch to the
> driver to check for a mac-address property is trivial, and we
> can probably come up with a decent way of parsing the device
> tree for USB devices, after all there is an existing spec for
> it (http://playground.sun.com/1275/bindings/usb/usb-1_0.ps).
>
> Arnd
>
> 8<------
> [PATCH] net/smscx5xx: demonstrate use of device tree for mac address
>
> This takes the MAC address for smsc75xx/smsc95xx USB network devices
> from a the device tree. This is required to get a usable persistent
> address on the popular beagleboard, whose hardware designers
> accidentally forgot that an ethernet device really requires an a
> MAC address to be functional.
>
> The smsc75xx and smsc95xx drivers are just two copies of the
> same code, so better fix both.
>
> Not tested!
>
> Signed-off-by: Arnd Bergmann <arnd.bergmann@linaro.org>

<snip>

Very nice.

Andy and Mark, would this patch work for you?

thanks,

greg k-h