Re: RFC: Platform data for onboard USB assets

Andy Green
2011-03-18T07:42:49Z

On 03/17/2011 11:25 PM, Somebody in the thread at some point said:
> On Thu, Mar 17, 2011 at 11:18:41PM +0000, Andy Green wrote:
>> On 03/17/2011 10:53 PM, Somebody in the thread at some point said:
>>
>>>> Not tested!
>>>>
>>>> Signed-off-by: Arnd Bergmann<arnd.bergmann@linaro.org>
>>>
>>> <snip>
>>>
>>> Very nice.
>>>
>>> Andy and Mark, would this patch work for you?
>>
>> You do realize this untested patch depends on 13 year old vapour
>> definition of general usb device tagging in Device Tree that does
>> not exist yet?
>
> As you get to create your own device tree for your board, it will then
> exist, right?

No, if you read Arnd's post you will find Device Tree does not support
targeting USB devices yet, and if you further read the 1998 document he
points to as the basis of actually implementing it, it seems to me at
least it'll be a little project yet to do that on Linux side.

That is why his "very nice" patch is untested, it literally doesn't work
as things stand so he is unable to test it. Yes, you will also need a
device tree for your board. When you ask if it "works for me", the
answer is it doesn't work for me, the author nor anybody else.

The Device Tree guys at first trashing and then co-opting this RFC has
the tendency to make me sound like a Device Tree basher. Actually I
don't think it's evil so long as it reflects the reality and necessity
that it is completely optional, there is an elephant in the room about
that and how it competes with platform_data. At the moment Device Tree
is "all things to all men", and few things stay like that for long.

-Andy