From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Paul Turner <pjt@google.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Dhaval Giani <dhaval.giani@gmail.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [patch 02/15] sched: validate CFS quota hierarchies
Date: Thu, 24 Mar 2011 12:01:26 +0530 [thread overview]
Message-ID: <20110324063126.GA2721@in.ibm.com> (raw)
In-Reply-To: <20110323030448.853861319@google.com>
On Tue, Mar 22, 2011 at 08:03:28PM -0700, Paul Turner wrote:
> Add constraints validation for CFS bandwidth hierachies.
>
> +static u64 normalize_cfs_quota(struct task_group *tg,
> + struct cfs_schedulable_data *d)
> +{
> + u64 quota, period;
> + struct load_weight lw;
> +
> + if (tg == d->tg) {
> + period = d->period;
> + quota = d->quota;
> + } else {
> + period = tg_get_cfs_period(tg);
> + quota = tg_get_cfs_quota(tg);
> + }
> +
> + if (quota == RUNTIME_INF)
> + return RUNTIME_INF;
> +
> + lw.weight = period;
> + lw.inv_weight = 0;
> +
> + return calc_delta_mine(quota, max_cfs_quota_period, &lw) - 1;
Time to rename calc_delta_mine to something more meaningful ?
Regards,
Bharata.
next prev parent reply other threads:[~2011-03-24 6:31 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 3:03 [patch 00/15] CFS Bandwidth Control V5 Paul Turner
2011-03-23 3:03 ` [patch 01/15] sched: introduce primitives to account for CFS bandwidth tracking Paul Turner
2011-03-24 12:38 ` Kamalesh Babulal
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 02/15] sched: validate CFS quota hierarchies Paul Turner
2011-03-23 10:39 ` torbenh
2011-03-23 20:49 ` Paul Turner
2011-03-24 6:31 ` Bharata B Rao [this message]
2011-04-08 17:01 ` Peter Zijlstra
2011-03-29 6:57 ` Hidetoshi Seto
2011-04-04 23:10 ` Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 03/15] sched: accumulate per-cfs_rq cpu usage Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-06 20:44 ` Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-06 20:47 ` Paul Turner
2011-03-23 3:03 ` [patch 04/15] sched: throttle cfs_rq entities which exceed their local quota Paul Turner
2011-03-23 5:09 ` Mike Galbraith
2011-03-23 20:53 ` Paul Turner
2011-03-24 6:36 ` Bharata B Rao
2011-03-24 7:40 ` Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-05 23:15 ` Paul Turner
2011-03-23 3:03 ` [patch 05/15] sched: unthrottle cfs_rq(s) who ran out of quota at period refresh Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-05 13:33 ` Peter Zijlstra
2011-04-05 13:28 ` Peter Zijlstra
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 06/15] sched: allow for positional tg_tree walks Paul Turner
2011-03-23 3:03 ` [patch 07/15] sched: prevent interactions between throttled entities and load-balance Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 08/15] sched: migrate throttled tasks on HOTPLUG Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-06 2:31 ` Paul Turner
2011-03-23 3:03 ` [patch 09/15] sched: add exports tracking cfs bandwidth control statistics Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 10/15] sched: (fixlet) dont update shares twice on on_rq parent Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 11/15] sched: hierarchical task accounting for SCHED_OTHER Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 12/15] sched: maintain throttled rqs as a list Paul Turner
2011-04-22 2:50 ` Hidetoshi Seto
2011-04-24 21:23 ` Paul Turner
2011-03-23 3:03 ` [patch 13/15] sched: expire slack quota using generation counters Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-06 7:22 ` Paul Turner
2011-04-06 8:15 ` Peter Zijlstra
2011-04-06 11:26 ` Peter Zijlstra
2011-03-23 3:03 ` [patch 14/15] sched: return unused quota on voluntary sleep Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-04-06 2:25 ` Paul Turner
2011-03-23 3:03 ` [patch 15/15] sched: add documentation for bandwidth control Paul Turner
2011-03-24 6:38 ` Bharata B Rao
2011-03-24 16:12 ` [patch 00/15] CFS Bandwidth Control V5 Bharata B Rao
2011-03-31 7:57 ` Xiao Guangrong
2011-04-04 23:10 ` Paul Turner
2011-04-05 13:28 ` Peter Zijlstra
2011-05-20 2:12 ` Test for CFS Bandwidth Control V6 Xiao Guangrong
2011-05-24 0:53 ` Hidetoshi Seto
2011-05-24 7:56 ` Xiao Guangrong
2011-06-08 2:54 ` Paul Turner
2011-06-08 5:55 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324063126.GA2721@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhaval.giani@gmail.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjt@google.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=vatsa@in.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).