The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	acpi4asus-user@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key
Date: Thu, 24 Mar 2011 08:14:15 -0500	[thread overview]
Message-ID: <20110324131414.GA20612@thinkpad-t410> (raw)
In-Reply-To: <AANLkTinZpt8qmHzhe4WyteMt-C-nkVNwEGQVvq3Nk9Lx@mail.gmail.com>

On Thu, Mar 24, 2011 at 08:33:33AM +0100, Corentin Chary wrote:
> On Wed, Mar 23, 2011 at 8:39 PM, Seth Forshee
> <seth.forshee@canonical.com> wrote:
> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> > ---
> >
> > This button is unusual. On press it emits scanocde 0xe4, on release
> > 0xe5, and when held for a few seconds it begins emitting 0xea about
> > twice per second. I chose to handle only the press event in order to
> > make it behave like the other hotkeys.
> >
> > Probably the closest thing to the intended function of this button
> > would be to alternate the display orientation between portrait and
> > landscape, but since there doesn't appear to be a keycode defined for
> > that function I went with KEY_PROG2. I'm open to other suggestions
> > however.
> 
> Hi,
> The manual says that under Windows, this is the "Home Key", so
> KEY_HOME would be more appropriate.

The manual does call it the Home Key (I missed previously that the
Express Gate description referred only to the quick boot mode), but the
description of the key operation reads:

  Shortly press this key to launch the Touch Gate touch screen
  interface. Press and hold this key to preview desktop rotation, and
  then release the key to finish desktop rotation.

Which doesn't really sound like a home key to me, and the icon above the
button also suggests display rotation. But then we don't seem to have a
code for that function, so KEY_PROG2 may be no better than KEY_HOME...

> Also, it would be great to preserve key up and key down informations
> (sparse keymap have an "autorelease" parameter to control that).

Okay, I'll add some special casing for this key to support that. Do you
suggest ignoring the 0xea scan codes?


  reply	other threads:[~2011-03-24 13:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 19:39 [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Seth Forshee
2011-03-24  7:33 ` Corentin Chary
2011-03-24 13:14   ` Seth Forshee [this message]
2011-03-24 13:26     ` Corentin Chary
2011-03-24 13:27     ` Chris Bagwell
2011-03-24 13:32       ` Chris Bagwell
2011-03-24 13:37       ` Seth Forshee
2011-03-24 13:40       ` Corentin Chary
2011-03-24 14:00         ` Chris Bagwell
2011-03-24 19:57           ` Seth Forshee
2011-03-24 20:03             ` [PATCH 1/2] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-24 20:03             ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-24 20:09               ` Seth Forshee
2011-03-25 13:28               ` Corentin Chary
2011-03-25 13:53                 ` Seth Forshee
2011-03-25 14:05                   ` Corentin Chary
2011-03-25 14:53                     ` Chris Bagwell
2011-03-25 15:13                       ` Seth Forshee
2011-03-25 15:43                       ` Corentin Chary
2011-03-25 16:17                         ` Seth Forshee
2011-03-25 16:14                     ` Dmitry Torokhov
2011-03-25 16:28                       ` Seth Forshee
2011-03-25 17:03                         ` Dmitry Torokhov
2011-03-25 18:58                           ` Seth Forshee
2011-03-27 17:13                             ` Dmitry Torokhov
2011-03-27 18:32                               ` Chris Bagwell
2011-03-27 19:11                                 ` Dmitry Torokhov
2011-03-28 13:46                                   ` Seth Forshee
2011-03-28 14:14                                     ` Corentin Chary
2011-03-28 18:33                                       ` Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 1/3] asus-wmi: Add callback for hotkey filtering Seth Forshee
2011-03-28 18:33                                         ` [PATCH v3 2/3] eeepc-wmi: Add support for T101MT Home/Express Gate key Seth Forshee
2011-03-29 12:29                                           ` Corentin Chary
2011-03-29 13:42                                             ` Seth Forshee
2011-03-29 13:47                                             ` Matthew Garrett
2011-03-30  7:46                                               ` Corentin Chary
2011-03-28 18:33                                         ` [PATCH v3 3/3] asus-wmi: Enable autorepeat for hotkey input device Seth Forshee
2011-03-29  6:33                                         ` [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key Dmitry Torokhov
2011-03-25 16:07           ` [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Dmitry Torokhov
2011-03-25 16:08             ` Corentin Chary
2011-03-25 16:05       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324131414.GA20612@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox