public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Justin TerAvest <teravest@google.com>
Cc: jaxboe@fusionio.com, m-ikeda@ds.jp.nec.com, ryov@valinux.co.jp,
	taka@valinux.co.jp, kamezawa.hiroyu@jp.fujitsu.com,
	righi.andrea@gmail.com, guijianfeng@cn.fujitsu.com,
	balbir@linux.vnet.ibm.com, ctalbott@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH v2 0/8] Provide cgroup isolation for buffered writes.
Date: Thu, 24 Mar 2011 09:56:57 -0400	[thread overview]
Message-ID: <20110324135657.GC20434@redhat.com> (raw)
In-Reply-To: <AANLkTi=mCAdX1KJrQRoi=mwtW=ZAANWo_Tzc+JNR34rr@mail.gmail.com>

On Wed, Mar 23, 2011 at 03:32:51PM -0700, Justin TerAvest wrote:

[..]
> > Ok, In the past I had tried it with 2 cgroups (running dd inside these
> > cgroups) and I had no success. I am wondering what has changed.
> 
> It could just be a difference in workload, or dd size, or filesystem?

Once you have sorted out the bug and I can boot my system, I will test
it to see what's happening.

> 
> >
> > In the past a high priority throttled process can very well try to
> > pick up a inode from low prio cgroup and start writting it and get
> > blocked. I believe similar thing should happen now.
> 
> You're right that it's very dependent on what inodes get picked up
> when from writeback.

So then above results should not be reproducible consistently? Are you
using additional patches internally to make this work reliably. My
concenrn is that it will not make sense to have half baked pieces 
in upstream kernel. That's why I was hoping that this piece can go in
once we have sorted out following.

- IO less throttling
- Per cgroup dirty ratio
- Some work w.r.t cgroup aware writeback.

In fact cgroup aware writeback can be part of this patch series once
first two pieces are in the kernel.

Thanks
Vivek

  reply	other threads:[~2011-03-24 13:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 23:08 [RFC] [PATCH v2 0/8] Provide cgroup isolation for buffered writes Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 1/8] cfq-iosched: add symmetric reference wrappers Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 2/8] block,fs,mm: IO cgroup tracking for buffered write Justin TerAvest
2011-03-23  4:52   ` KAMEZAWA Hiroyuki
2011-03-23 17:21     ` Justin TerAvest
2011-03-24  8:26       ` KAMEZAWA Hiroyuki
2011-03-22 23:08 ` [PATCH v2 3/8] cfq-iosched: Make async queues per cgroup Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 4/8] block: Modify CFQ to use IO tracking information Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 5/8] cfq: Fix up tracked async workload length Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 6/8] cfq: add per cgroup writeout done by flusher stat Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 7/8] block: Per cgroup request descriptor counts Justin TerAvest
2011-03-22 23:08 ` [PATCH v2 8/8] cfq: Don't allow preemption across cgroups Justin TerAvest
2011-03-23  1:27 ` [RFC] [PATCH v2 0/8] Provide cgroup isolation for buffered writes Vivek Goyal
2011-03-23 16:27   ` Justin TerAvest
2011-03-23 20:06     ` Vivek Goyal
2011-03-23 22:32       ` Justin TerAvest
2011-03-24 13:56         ` Vivek Goyal [this message]
2011-03-25  1:51           ` Justin TerAvest
2011-03-25  7:46 ` Balbir Singh
2011-03-28 15:21   ` Justin TerAvest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324135657.GC20434@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=ctalbott@google.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jaxboe@fusionio.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-ikeda@ds.jp.nec.com \
    --cc=righi.andrea@gmail.com \
    --cc=ryov@valinux.co.jp \
    --cc=taka@valinux.co.jp \
    --cc=teravest@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox