Re: [PATCH RFC] x86: avoid atomic operation in test_and_set_bit_lock if possible

Ingo Molnar
2011-03-25T09:23:03Z

* Andi Kleen <andi@firstfloor.org> wrote:

> > never EVER seen any good explanation of why that particular sh*t
> > argument would b true. It seems to be purely about politics, where
> > some idiotic vendor (namely HP) has convinced Intel that they really
> > need it. To the point where some engineers seem to have bought into
> > the whole thing and actually believe that fairy tale ("firmware can do
> > better" - hah! They must be feeding people some bad drugs at the
> > cafeteria)
>
> For the record I don't think it's a good idea for the BIOS to do
> this (and I'm not aware of any engineer who does),

There's really just two sane options:

- complain about the BIOS corrupting CPU state and refusing to use the PMU
- complain about the BIOS corrupting CPU state and using the PMU against the BIOS

We went for the first one but i'll be more than glad to implement Linus's much
more aggressive second option.

Btw., for the record, the thing you have been advocating in the past was a
third option: for the kernel to step aside quietly and to let the BIOS corrupt
a counter or two. You even sent us some sort of BIOS specification about how to
implement that. That's pretty much the worst solution imaginable.

Thanks,

Ingo