Re: [RFC PATCHv2 1/4] drivers/otp: add initial support for OTP memory

Arnd Bergmann
2011-03-26T20:51:55Z

On Saturday 26 March 2011 18:55:39 Mike Frysinger wrote:
> >> i would add an ABI field here too so if in the future we want to add
> >> stuff, we can do so without adding new ioctls. like "u16 version; u16
> >> flags;". then in the ioctl, if version isnt 0, we return ENOTSUP. in
> >> the future, we can add flags or bump the version.
> >
> > No, versioned APIs are just a pain to maintain, it's easier to add
> > new ioctl commands when necessary.
> > Note that the kernel would always have to support all versions of
> > the API anyway.
>
> adding at least a flags field then should be fine

Fine with me, if you can name at least one possible use for a flag.

I think it would be better without a flags field, but it's not a
problem if you insist on having it.

Arnd