Re: [RFC PATCHv2 1/4] drivers/otp: add initial support for OTP memory

Arnd Bergmann
2011-03-26T10:54:23Z

On Saturday 26 March 2011 03:16:48 Mike Frysinger wrote:
> On Fri, Mar 25, 2011 at 20:21, Jamie Iles wrote:
> > For the actual ioctl() we should assume byte addressing rather than
> > words though and do the conversion in the driver so we can cope with
> > devices that don't have 64-bit words and do the locking on a looping
> > word-by-word basis.
> >
> > struct otp_lock_req {
> > __u32 start_addr;
> > __u32 byte_count;
> > };

Looks good to me.

> i would add an ABI field here too so if in the future we want to add
> stuff, we can do so without adding new ioctls. like "u16 version; u16
> flags;". then in the ioctl, if version isnt 0, we return ENOTSUP. in
> the future, we can add flags or bump the version.

No, versioned APIs are just a pain to maintain, it's easier to add
new ioctl commands when necessary.
Note that the kernel would always have to support all versions of
the API anyway.

Arnd