Re: [RFC PATCHv2 1/4] drivers/otp: add initial support for OTP memory

Mike Frysinger
2011-03-27T03:52:26Z

On Sat, Mar 26, 2011 at 16:51, Arnd Bergmann wrote:
> On Saturday 26 March 2011 18:55:39 Mike Frysinger wrote:
>> >> i would add an ABI field here too so if in the future we want to add
>> >> stuff, we can do so without adding new ioctls.  like "u16 version; u16
>> >> flags;".  then in the ioctl, if version isnt 0, we return ENOTSUP.  in
>> >> the future, we can add flags or bump the version.
>> >
>> > No, versioned APIs are just a pain to maintain, it's easier to add
>> > new ioctl commands when necessary.
>> > Note that the kernel would always have to support all versions of
>> > the API anyway.
>>
>> adding at least a flags field then should be fine
>
> Fine with me, if you can name at least one possible use for a flag.

i tend to assume that i cant think of all cases when i first write up
something, so better to leave a hole for the future ;)
-mike