Re: [RFC PATCHv2 1/4] drivers/otp: add initial support for OTP memory

Jamie Iles
2011-03-25T22:23:53Z

Hi Arnd,

On Fri, Mar 25, 2011 at 09:12:22PM +0100, Arnd Bergmann wrote:
> On Thursday 24 March 2011 16:21:08 Jamie Iles wrote:
> > OTP memory is typically found in some embedded devices and can be
> > used for storing boot code, cryptographic keys and other persistent
> > information onchip. This patch adds a generic layer that devices can
> > register OTP with and allows access through a set of character
> > device nodes.
>
> Looks very nice overall, but I have a few minor comments.

Thanks for taking the time to look at this. I think I've addressed all
of your comments in the v3 series apart from defining OTP (which really
does need to be done so I'll make sure I do that in v4) and the sysfs
bus/class stuff. I understand that the intention is for a bus to
actually represent a subsystem so that does make sense to me (I think!).

Jamie