public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: Use new irq_move functions
@ 2011-03-24 20:37 Thomas Gleixner
  2011-03-25 10:04 ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2011-03-24 20:37 UTC (permalink / raw)
  To: LKML; +Cc: ian.campbell, Jeremy Fitzhardinge, konrad.wilk

These functions take irq_data as an argument and avoid a redundant
lookup in the sparse irq case.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/events.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6-tip/drivers/xen/events.c
===================================================================
--- linux-2.6-tip.orig/drivers/xen/events.c
+++ linux-2.6-tip/drivers/xen/events.c
@@ -585,7 +585,7 @@ static void ack_pirq(struct irq_data *da
 {
 	int evtchn = evtchn_from_irq(data->irq);
 
-	move_native_irq(data->irq);
+	irq_move_irq(data);
 
 	if (VALID_EVTCHN(evtchn)) {
 		mask_evtchn(evtchn);
@@ -1339,7 +1339,7 @@ static void ack_dynirq(struct irq_data *
 {
 	int evtchn = evtchn_from_irq(data->irq);
 
-	move_masked_irq(data->irq);
+	irq_move_masked_irq(data);
 
 	if (VALID_EVTCHN(evtchn))
 		unmask_evtchn(evtchn);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: Use new irq_move functions
  2011-03-24 20:37 [PATCH] xen: Use new irq_move functions Thomas Gleixner
@ 2011-03-25 10:04 ` Ian Campbell
  2011-03-25 11:54   ` Thomas Gleixner
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2011-03-25 10:04 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: LKML, Jeremy Fitzhardinge, konrad.wilk@oracle.com

On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> These functions take irq_data as an argument and avoid a redundant
> lookup in the sparse irq case.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Looks good to me.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Do you want to carry this in your tree or shall we pick it up? (not sure
if this is part of a wider treewide series or not)

> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  drivers/xen/events.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6-tip/drivers/xen/events.c
> ===================================================================
> --- linux-2.6-tip.orig/drivers/xen/events.c
> +++ linux-2.6-tip/drivers/xen/events.c
> @@ -585,7 +585,7 @@ static void ack_pirq(struct irq_data *da
>  {
>  	int evtchn = evtchn_from_irq(data->irq);
>  
> -	move_native_irq(data->irq);
> +	irq_move_irq(data);
>  
>  	if (VALID_EVTCHN(evtchn)) {
>  		mask_evtchn(evtchn);
> @@ -1339,7 +1339,7 @@ static void ack_dynirq(struct irq_data *
>  {
>  	int evtchn = evtchn_from_irq(data->irq);
>  
> -	move_masked_irq(data->irq);
> +	irq_move_masked_irq(data);
>  
>  	if (VALID_EVTCHN(evtchn))
>  		unmask_evtchn(evtchn);



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: Use new irq_move functions
  2011-03-25 10:04 ` Ian Campbell
@ 2011-03-25 11:54   ` Thomas Gleixner
  2011-03-25 12:23     ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2011-03-25 11:54 UTC (permalink / raw)
  To: Ian Campbell; +Cc: LKML, Jeremy Fitzhardinge, konrad.wilk@oracle.com

On Fri, 25 Mar 2011, Ian Campbell wrote:

> On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> > These functions take irq_data as an argument and avoid a redundant
> > lookup in the sparse irq case.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> Looks good to me.
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Do you want to carry this in your tree or shall we pick it up? (not sure
> if this is part of a wider treewide series or not)

Works either way as long as we get it into .39 so we can cleanup the
old stuff. Ditto for the namespace.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: Use new irq_move functions
  2011-03-25 11:54   ` Thomas Gleixner
@ 2011-03-25 12:23     ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-03-25 12:23 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Ian Campbell, LKML, Jeremy Fitzhardinge

On Fri, Mar 25, 2011 at 12:54:09PM +0100, Thomas Gleixner wrote:
> On Fri, 25 Mar 2011, Ian Campbell wrote:
> 
> > On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> > > These functions take irq_data as an argument and avoid a redundant
> > > lookup in the sparse irq case.
> > > 
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > 
> > Looks good to me.
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > Do you want to carry this in your tree or shall we pick it up? (not sure
> > if this is part of a wider treewide series or not)
> 
> Works either way as long as we get it into .39 so we can cleanup the
> old stuff. Ditto for the namespace.

I will take them and push them out next week.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-03-25 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 20:37 [PATCH] xen: Use new irq_move functions Thomas Gleixner
2011-03-25 10:04 ` Ian Campbell
2011-03-25 11:54   ` Thomas Gleixner
2011-03-25 12:23     ` Konrad Rzeszutek Wilk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox