Re: [GIT PULL] Core block IO bits for 2.6.39

Jens Axboe
2011-03-26T16:53:54Z

On 2011-03-26 17:48, Linus Torvalds wrote:
> On Fri, Mar 25, 2011 at 11:29 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>> +
>> + /* Use 3ms as that was the old plug delay */
>> + blk_delay_queue(q, msecs_to_jiffies(3));
>
> That's bogus. blk_delay_queue() already takes msecs, not jiffies.

You are right, braino.

> Also, do we really need to delay every unplug like this? It seems sad.
> A 3ms delay is a long time these days - admittedly most people
> hopefully use ATA these days if they have an SSD or something, but
> still..

Depends on whether you want the 'call me back, I ran into busy this
time' or the 'recall me immediately'.

I'll take a look at the IDE case tonight and submit a real fix.

--
Jens Axboe