From: Andi Kleen <andi@firstfloor.org>
To: Alessio Igor Bogani <abogani@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
Ian Lance Taylor <ian@airs.com>, Tim Bird <tim.bird@am.sony.com>
Subject: Re: [PATCH 2/2] Replace the linear search with a binary search for locate the symbols
Date: Fri, 25 Mar 2011 20:49:46 +0100 [thread overview]
Message-ID: <20110325194946.GQ21838@one.firstfloor.org> (raw)
In-Reply-To: <AANLkTinW4GA094Yz94Y0qTEJvjOmRe4_C+5yc7_VcKM3@mail.gmail.com>
On Fri, Mar 25, 2011 at 05:30:11PM +0100, Alessio Igor Bogani wrote:
> Dear Mr. Kleen,
>
> 2011/3/25 Andi Kleen <andi@firstfloor.org>:
> [...]
> >> > Patch looks good to me. SORT is a nice trick, too bad it won't
> >> > work for the main kernel.
> >>
> >> Why not?
> >
> > Because kallsyms is supposed to be in address order, not name order.
>
> What should that break exactly?
> Thanks you very much!
For kallsyms you either look it up by address or by name.
You can only sort for one of those.
Most likely address lookup is more important.
If you sorted by name you would make the address case slower.
Then the order is also exposed in /proc/kallsyms. If people use
this like System.map they likely expect numeric order.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2011-03-25 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 21:00 [PATCH 0/2] Speed up the symbols' resolution process Alessio Igor Bogani
2011-03-23 21:00 ` [PATCH 1/2] Let Linker sort the symbols Alessio Igor Bogani
2011-03-23 21:00 ` [PATCH 2/2] Replace the linear search with a binary search for locate " Alessio Igor Bogani
2011-03-24 15:54 ` Andi Kleen
2011-03-25 5:14 ` Rusty Russell
2011-03-25 15:41 ` Andi Kleen
2011-03-25 16:30 ` Alessio Igor Bogani
2011-03-25 19:49 ` Andi Kleen [this message]
2011-03-25 21:31 ` Alessio Igor Bogani
2011-03-26 20:04 ` Andi Kleen
2011-03-28 8:22 ` Alessio Igor Bogani
2011-03-28 15:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325194946.GQ21838@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=abogani@kernel.org \
--cc=ian@airs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox