linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: sedat.dilek@gmail.com
Cc: Josh Triplett <josh@joshtriplett.org>,
	linux-next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	"Theodore Ts'o" <tytso@mit.edu>, Jens Axboe <axboe@kernel.dk>,
	Tejun Heo <tj@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
	Nick Piggin <npiggin@kernel.dk>
Subject: Re: linux-next: Tree for March 25 (Call trace: RCU|workqueues|block|VFS|ext4 related?)
Date: Sat, 26 Mar 2011 22:07:20 -0700	[thread overview]
Message-ID: <20110327050720.GA31424@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110327032529.GC2322@linux.vnet.ibm.com>

On Sat, Mar 26, 2011 at 08:25:29PM -0700, Paul E. McKenney wrote:
> On Sun, Mar 27, 2011 at 03:30:34AM +0200, Sedat Dilek wrote:
> > On Sun, Mar 27, 2011 at 1:09 AM, Paul E. McKenney
> > <paulmck@linux.vnet.ibm.com> wrote:
> > > On Sat, Mar 26, 2011 at 11:15:22PM +0100, Sedat Dilek wrote:

[ . . . ]

> > >> But then came RCU :-(.
> > >
> > > Well, if it turns out to be a problem in RCU I will certainly apologize.
> > >
> > 
> > No, that's not so dramatic.
> > Dealing with this RCU issue has nice side-effects: I remembered (and
> > finally did) to use a reduced kernel-config set.
> > The base for it I created with 'make localmodconfig' and did some
> > manual fine-tuning afterwards (throw out media, rc, dvd, unneeded FSs,
> > etc.).
> > Also, I can use fresh gcc-4.6 (4.6.0-1) from the official Debian repos.
> > 
> > So, I started building with
> > "revert-rcu-patches/0001-Revert-rcu-introduce-kfree_rcu.patch".
> > I will let you know.
> 
> And please also check for tasks consuming all available CPU.

And I still cannot reproduce with the full RCU stack (but based off of
2.6.38 rather than -next).  Nevertheless, if you would like to try a
speculative patch, here you go.

							Thanx, Paul

------------------------------------------------------------------------

rcu: further lower priority in rcu_yield()

Although rcu_yield() dropped from real-time to normal priority, there
is always the possibility that the competing tasks have been niced.
So nice to 19 in rcu_yield() to help ensure that other tasks have a
better chance of running.
    
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 759f54b..5477764 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1492,6 +1492,7 @@ static void rcu_yield(void (*f)(unsigned long), unsigned long arg)
 	mod_timer(&yield_timer, jiffies + 2);
 	sp.sched_priority = 0;
 	sched_setscheduler_nocheck(current, SCHED_NORMAL, &sp);
+	set_user_nice(current, 19);
 	schedule();
 	sp.sched_priority = RCU_KTHREAD_PRIO;
 	sched_setscheduler_nocheck(current, SCHED_FIFO, &sp);

  reply	other threads:[~2011-03-27  5:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 10:16 linux-next: Tree for March 25 (Call trace: RCU|workqueues|block|VFS|ext4 related?) Sedat Dilek
2011-03-25 13:05 ` Sedat Dilek
2011-03-25 15:55   ` Josh Triplett
2011-03-25 16:25     ` Sedat Dilek
2011-03-25 16:42     ` Paul E. McKenney
2011-03-25 16:51       ` Sedat Dilek
2011-03-25 17:40         ` Sedat Dilek
2011-03-25 17:48           ` Paul E. McKenney
2011-03-25 19:42             ` Sedat Dilek
2011-03-26  3:42               ` Paul E. McKenney
2011-03-26  8:11                 ` Sedat Dilek
2011-03-26 15:53                   ` Paul E. McKenney
2011-03-26 12:34                 ` Sedat Dilek
2011-03-26 16:02                   ` Paul E. McKenney
2011-03-26 22:15                     ` Sedat Dilek
2011-03-27  0:09                       ` Paul E. McKenney
2011-03-27  1:30                         ` Sedat Dilek
2011-03-27  3:25                           ` Paul E. McKenney
2011-03-27  5:07                             ` Paul E. McKenney [this message]
2011-03-27 12:26                               ` Sedat Dilek
2011-03-27 21:32                                 ` Paul E. McKenney
2011-03-27 21:48                                   ` Sedat Dilek
2011-03-28  4:08                                     ` Paul E. McKenney
2011-03-28 12:33                                       ` Sedat Dilek
2011-03-28 13:24                                         ` Paul E. McKenney
2011-03-28 15:11                                           ` Paul E. McKenney
2011-03-28 16:38                                             ` Sedat Dilek
2011-03-28 16:46                                               ` Sedat Dilek
2011-03-29  0:10                                                 ` Paul E. McKenney
2011-03-29  2:42                                                   ` Sedat Dilek
2011-03-29  4:17                                                     ` Paul E. McKenney
2011-03-29  4:39                                           ` Sedat Dilek
2011-03-29  5:48                                             ` Paul E. McKenney
2011-03-25 17:44         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110327050720.GA31424@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=npiggin@kernel.dk \
    --cc=randy.dunlap@oracle.com \
    --cc=sedat.dilek@gmail.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tj@kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).