* [PATCH] Fixed the format: lines over 80 characters .
@ 2011-03-27 3:07 wanlong.gao
2011-03-27 12:53 ` Alexey Dobriyan
0 siblings, 1 reply; 6+ messages in thread
From: wanlong.gao @ 2011-03-27 3:07 UTC (permalink / raw)
To: greg, harryxiyou; +Cc: linux-kernel, Wanlong Gao
From: Wanlong Gao <wanlong.gao@gmail.com>
Lines over 80 characters
FILE: janz-cmodio.c:273
Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
---
drivers/mfd/janz-cmodio.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
index 36a166b..fb29d23 100644
--- a/drivers/mfd/janz-cmodio.c
+++ b/drivers/mfd/janz-cmodio.c
@@ -270,8 +270,10 @@ static void __devexit cmodio_pci_remove(struct pci_dev *dev)
/* The list of devices that this module will support */
static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+ { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+ PCI_VENDOR_ID_JANZ, 0x0101 },
+ { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+ PCI_VENDOR_ID_JANZ, 0x0100 },
{ 0, }
};
MODULE_DEVICE_TABLE(pci, cmodio_pci_ids);
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Fixed the format: lines over 80 characters .
2011-03-27 3:07 [PATCH] Fixed the format: lines over 80 characters wanlong.gao
@ 2011-03-27 12:53 ` Alexey Dobriyan
2011-03-27 14:12 ` wanlong.gao
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2011-03-27 12:53 UTC (permalink / raw)
To: wanlong.gao; +Cc: greg, harryxiyou, linux-kernel
On Sun, Mar 27, 2011 at 11:07:24AM +0800, wanlong.gao@gmail.com wrote:
> Lines over 80 characters
> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },
NAK, this is less readable.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: [PATCH] Fixed the format: lines over 80 characters .
2011-03-27 12:53 ` Alexey Dobriyan
@ 2011-03-27 14:12 ` wanlong.gao
2011-03-27 14:31 ` wanlong.gao
2011-03-28 4:59 ` Harry Wei
2 siblings, 0 replies; 6+ messages in thread
From: wanlong.gao @ 2011-03-27 14:12 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: greg, harryxiyou, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 976 bytes --]
I see, thanks .
------------------
wanlong.gao
2011-03-27
-------------------------------------------------------------
·¢¼þÈË£ºAlexey Dobriyan
·¢ËÍÈÕÆÚ£º2011-03-27 21:54:05
ÊÕ¼þÈË£ºwanlong.gao
³ËÍ£ºgreg; harryxiyou; linux-kernel
Ö÷Ì⣺Re: [PATCH] Fixed the format: lines over 80 characters .
On Sun, Mar 27, 2011 at 11:07:24AM +0800, wanlong.gao@gmail.com wrote:
> Lines over 80 characters
> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },
NAK, this is less readable.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: [PATCH] Fixed the format: lines over 80 characters .
2011-03-27 12:53 ` Alexey Dobriyan
2011-03-27 14:12 ` wanlong.gao
@ 2011-03-27 14:31 ` wanlong.gao
2011-03-28 17:30 ` Steven Rostedt
2011-03-28 4:59 ` Harry Wei
2 siblings, 1 reply; 6+ messages in thread
From: wanlong.gao @ 2011-03-27 14:31 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: greg, harryxiyou, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1024 bytes --]
But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?
-------------------------------------------------------------
·¢¼þÈË£ºAlexey Dobriyan
·¢ËÍÈÕÆÚ£º2011-03-27 21:54:05
ÊÕ¼þÈË£ºwanlong.gao
³ËÍ£ºgreg; harryxiyou; linux-kernel
Ö÷Ì⣺Re: [PATCH] Fixed the format: lines over 80 characters .
On Sun, Mar 27, 2011 at 11:07:24AM +0800, wanlong.gao@gmail.com wrote:
> Lines over 80 characters
> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },
NAK, this is less readable.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Re: [PATCH] Fixed the format: lines over 80 characters .
2011-03-27 14:31 ` wanlong.gao
@ 2011-03-28 17:30 ` Steven Rostedt
0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2011-03-28 17:30 UTC (permalink / raw)
To: wanlong.gao; +Cc: Alexey Dobriyan, greg, harryxiyou, linux-kernel
On Sun, Mar 27, 2011 at 10:31:46PM +0800, wanlong.gao wrote:
>
>
> But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?
I too agree that it is less readable. Even if I read it in a 80 col
screen (which I seldom do), I could easily scroll to the right. This is
not code, its a table, and having each item on its own row makes it much
easier to read what field goes with what item.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fixed the format: lines over 80 characters .
2011-03-27 12:53 ` Alexey Dobriyan
2011-03-27 14:12 ` wanlong.gao
2011-03-27 14:31 ` wanlong.gao
@ 2011-03-28 4:59 ` Harry Wei
2 siblings, 0 replies; 6+ messages in thread
From: Harry Wei @ 2011-03-28 4:59 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: wanlong.gao, linux-kernel, greg
On Sun, Mar 27, 2011 at 03:53:59PM +0300, Alexey Dobriyan wrote:
> On Sun, Mar 27, 2011 at 11:07:24AM +0800, wanlong.gao@gmail.com wrote:
> > Lines over 80 characters
> >
> > Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> NAK, this is less readable.
Hi Alexey,
I don't know how above patch decreases the readable for us.
Well, we should recognize it may be less readable after cleaning the
lines, which are over 80 characters. But this is well for me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-28 17:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-27 3:07 [PATCH] Fixed the format: lines over 80 characters wanlong.gao
2011-03-27 12:53 ` Alexey Dobriyan
2011-03-27 14:12 ` wanlong.gao
2011-03-27 14:31 ` wanlong.gao
2011-03-28 17:30 ` Steven Rostedt
2011-03-28 4:59 ` Harry Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox