From: Feng Tang <feng.tang@intel.com>
To: Greg KH <greg@kroah.com>
Cc: "Lu, Guanqun" <guanqun.lu@intel.com>,
"meego-kernel@lists.meego.com" <meego-kernel@lists.meego.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"Fu, Michael" <michael.fu@intel.com>,
"Wang, Xingchao" <xingchao.wang@intel.com>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Kp, Jeeja" <jeeja.kp@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Feng Tang <feng.tang@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Jekyll Lai <jekyll_lai@wistron.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 1/2] mrst: export get_gpio_by_name() function
Date: Mon, 28 Mar 2011 14:25:18 +0800 [thread overview]
Message-ID: <20110328142518.2af6b2e2@feng-i7> (raw)
In-Reply-To: <20110328055024.GA27949@kroah.com>
Hi Greg,
On Mon, 28 Mar 2011 13:50:24 +0800
Greg KH <greg@kroah.com> wrote:
> On Mon, Mar 28, 2011 at 10:29:19AM +0800, Lu Guanqun wrote:
> > Export get_gpio_by_name() function and make its name more focused.
> > We are doing this because currently get_gpio_by_name() is only used
> > by the devices exported from SFI DEVS table, but it is also useful
> > for other PCI devices which also use the GPIO lines, and have their
> > gpio infos in the SFI GPIO table.
>
> As others pointed out, don't change the name of this function.
Yes, will keep it in mind
>
> Also, this is only needed by the one staging driver, right?
Yes, currently it is only needed by the intel_sst driver in stating.
Thanks,
Feng
next prev parent reply other threads:[~2011-03-28 6:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301279360-9839-1-git-send-email-guanqun.lu@intel.com>
2011-03-28 2:29 ` [PATCH v9 1/2] mrst: export get_gpio_by_name() function Lu Guanqun
2011-03-28 2:34 ` Arjan van de Ven
2011-03-28 2:47 ` Feng Tang
2011-03-28 2:47 ` Arjan van de Ven
2011-03-28 2:59 ` Lu Guanqun
2011-03-28 3:00 ` Feng Tang
2011-03-28 3:00 ` [Meego-kernel] " Arjan van de Ven
2011-03-28 3:12 ` Feng Tang
2011-03-28 9:46 ` Alan Cox
2011-03-28 5:50 ` Greg KH
2011-03-28 6:25 ` Feng Tang [this message]
2011-03-28 2:29 ` [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line Lu Guanqun
2011-03-28 2:35 ` Arjan van de Ven
2011-03-28 2:53 ` Lu Guanqun
2011-03-28 3:19 ` Jeff_Cheng
2011-03-28 5:51 ` Greg KH
2011-03-28 16:18 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328142518.2af6b2e2@feng-i7 \
--to=feng.tang@intel.com \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=feng.tang@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=greg@kroah.com \
--cc=guanqun.lu@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jeeja.kp@intel.com \
--cc=jekyll_lai@wistron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@lists.meego.com \
--cc=michael.fu@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
--cc=x86@kernel.org \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox