From: Arnd Bergmann <arnd@arndb.de>
To: "Par-Gunnar Hjalmdahl" <par-gunnar.p.hjalmdahl@stericsson.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
devel@driverdev.osuosl.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
Pavan Savoy <pavan_savoy@sify.com>,
Vitaly Wool <vitalywool@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marcel Holtmann <marcel@holtmann.org>,
Lukasz Rymanowski <Lukasz.Rymanowski@tieto.com>,
Linus Walleij <linus.walleij@stericsson.com>,
"Par-Gunnar Hjalmdahl" <pghatwork@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v2 2/2] mach-ux500: Add CG2900 devices
Date: Mon, 28 Mar 2011 15:00:38 +0200 [thread overview]
Message-ID: <201103281500.38954.arnd@arndb.de> (raw)
In-Reply-To: <1301302992-10671-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com>
On Monday 28 March 2011, Par-Gunnar Hjalmdahl wrote:
> diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c
> index d8e5a52..16b7343 100644
> --- a/arch/arm/mach-ux500/board-mop500.c
> +++ b/arch/arm/mach-ux500/board-mop500.c
> @@ -417,6 +417,8 @@ static void __init mop500_init_machine(void)
>
> platform_device_register(&ab8500_device);
>
> + cg2900_init_board();
> +
> i2c_register_board_info(0, mop500_i2c0_devices,
> ARRAY_SIZE(mop500_i2c0_devices));
> i2c_register_board_info(2, mop500_i2c2_devices,
Not exactly what I had in mind, but probably good enough for a start.
This adds a dependency from core code to the staging driver now,
which shouldn't be there. I suppose we can add
"Clean up device registration path to register the main device from board code"
to the TODO file.
Arnd
next prev parent reply other threads:[~2011-03-28 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 9:03 [PATCH v2 2/2] mach-ux500: Add CG2900 devices Par-Gunnar Hjalmdahl
2011-03-28 13:00 ` Arnd Bergmann [this message]
2011-03-28 14:12 ` Greg KH
2011-03-28 14:29 ` Par-Gunnar HJALMDAHL
2011-03-28 14:39 ` Greg KH
2011-03-28 14:59 ` Arnd Bergmann
2011-03-28 14:47 ` Arnd Bergmann
2011-03-28 14:40 ` Vitaly Wool
2011-03-28 14:49 ` Arnd Bergmann
2011-03-29 6:20 ` Par-Gunnar HJALMDAHL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103281500.38954.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Lukasz.Rymanowski@tieto.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathieu.poirier@linaro.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
--cc=pavan_savoy@sify.com \
--cc=pghatwork@gmail.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox