public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dlm: Remove superfluous call to recalc_sigpending()
@ 2011-03-24 13:56 Matt Fleming
  2011-03-28 15:23 ` David Teigland
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Fleming @ 2011-03-24 13:56 UTC (permalink / raw)
  To: linux-kernel
  Cc: Matt Fleming, Christine Caulfield, David Teigland, cluster-devel

From: Matt Fleming <matt.fleming@linux.intel.com>

recalc_sigpending() is called within sigprocmask(), so there is no
need call it again after sigprocmask() has returned.

Signed-off-by: Matt Fleming <matt.fleming@linux.intel.com>
---
 fs/dlm/user.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index 66d6c16..d9da93c 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -632,7 +632,6 @@ static ssize_t device_write(struct file *file, const char __user *buf,
 
  out_sig:
 	sigprocmask(SIG_SETMASK, &tmpsig, NULL);
-	recalc_sigpending();
  out_free:
 	kfree(kbuf);
 	return error;
-- 
1.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dlm: Remove superfluous call to recalc_sigpending()
  2011-03-24 13:56 [PATCH] dlm: Remove superfluous call to recalc_sigpending() Matt Fleming
@ 2011-03-28 15:23 ` David Teigland
  0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2011-03-28 15:23 UTC (permalink / raw)
  To: Matt Fleming
  Cc: linux-kernel, Matt Fleming, Christine Caulfield, cluster-devel

On Thu, Mar 24, 2011 at 01:56:47PM +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@linux.intel.com>
> 
> recalc_sigpending() is called within sigprocmask(), so there is no
> need call it again after sigprocmask() has returned.

Thanks, pushed to dlm.git next.
Dave


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-28 15:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 13:56 [PATCH] dlm: Remove superfluous call to recalc_sigpending() Matt Fleming
2011-03-28 15:23 ` David Teigland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox