Re: [GIT PATCH] Fix memory leak in qcserial driver

Greg KH
2011-03-28T14:32:41Z

On Mon, Mar 28, 2011 at 03:06:26PM +0100, Steven Hardy wrote:
> Hi,
>
> I've been experimenting with kmemleak and noticed a recurring leak warning whenever I load & unload the qcserial driver.
>
> Inspection of the code seems to indicate the leak is the serial->private data allocated in the qcprobe() function,
> which is never freed (apart from in some of the qcprobe error paths) as far as I can tell.
>
> The patch below fixes the following problems:

<snip>

Can you fix your email client to properly wrap your lines?

Also, as you do 3 different things here, can you break this into 3
patches and resend them?

thanks,

greg k-h