From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755334Ab1C1TCA (ORCPT ); Mon, 28 Mar 2011 15:02:00 -0400 Received: from tango.tkos.co.il ([62.219.50.35]:43402 "EHLO tango.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab1C1TB6 (ORCPT ); Mon, 28 Mar 2011 15:01:58 -0400 X-Greylist: delayed 704 seconds by postgrey-1.27 at vger.kernel.org; Mon, 28 Mar 2011 15:01:57 EDT Date: Mon, 28 Mar 2011 20:49:11 +0200 From: Baruch Siach To: Randy Dunlap Cc: Stephen Rothwell , linux-i2c@vger.kernel.org, linux-next@vger.kernel.org, LKML , khali@linux-fr.org, ben-linux@fluff.org Subject: Re: [PATCH -next resend] i2c: designware-pcidrv depends on PCI Message-ID: <20110328184725.GA12158@tarshish> References: <20110328081043.0a71e36b.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110328081043.0a71e36b.randy.dunlap@oracle.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On Mon, Mar 28, 2011 at 08:10:43AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > Fixes these build errors: > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region' > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' > Well, I haven't seen these PCI support patches until now, but this seems to be OK, so, FWIW: Acked-by: Baruch Siach Thanks, baruch > Signed-off-by: Randy Dunlap > Cc: Baruch Siach > --- > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig > +++ linux-next-20110316/drivers/i2c/busses/Kconfig > @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM > > config I2C_DESIGNWARE_PCI > tristate "Synopsys DesignWare PCI" > + depends on PCI > help > If you say yes to this option, support will be included for the > Synopsys DesignWare I2C adapter. Only master mode is supported. > -- -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -