From: Oleg Nesterov <oleg@redhat.com>
To: Roland Dreier <roland@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Julien Tinnes <jln@google.com>,
Klaus Dittrich <kladit@arcor.de>, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH v2] Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo
Date: Tue, 29 Mar 2011 14:19:37 +0200 [thread overview]
Message-ID: <20110329121937.GA27497@redhat.com> (raw)
In-Reply-To: <1301346815-6755-1-git-send-email-roland@kernel.org>
On 03/28, Roland Dreier wrote:
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 324eff5..b2bfa3a 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2437,7 +2437,7 @@ SYSCALL_DEFINE3(rt_sigqueueinfo, pid_t, pid, int, sig,
> /* Not even root can pretend to send signals from the kernel.
> * Nor can they impersonate a kill()/tgkill(), which adds source info.
> */
> - if (info.si_code != SI_QUEUE) {
> + if (info.si_code >= 0 || info.si_code == SI_TKILL) {
> /* We used to allow any < 0 si_code */
> WARN_ON_ONCE(info.si_code < 0);
This is equivalent to WARN_ON_ONCE(SI_TKILL)... doesn't matter, please ignore.
Thanks, I think -stable needs this patch asap. It turns out 2.6.32.36, 2.6.33.9,
2.6.37.6 and 2.6.38.2 pulled da48524eb20662618854bb3df2db01fc65f3070c.
If this change breaks something too, we can make even more conservative check.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2011-03-29 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 21:13 [PATCH v2] Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo Roland Dreier
2011-03-28 21:24 ` Julien Tinnes
2011-03-29 12:19 ` Oleg Nesterov [this message]
2011-03-29 17:26 ` Roland Dreier
2011-04-11 18:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329121937.GA27497@redhat.com \
--to=oleg@redhat.com \
--cc=gregkh@suse.de \
--cc=jln@google.com \
--cc=kladit@arcor.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox