From: Vivek Goyal <vgoyal@redhat.com>
To: Justin TerAvest <teravest@google.com>
Cc: Jens Axboe <jaxboe@fusionio.com>,
lkml <linux-kernel@vger.kernel.org>,
Chad Talbott <ctalbott@google.com>
Subject: Re: Why do we use cpu nice priority for ioprio?
Date: Wed, 30 Mar 2011 14:34:46 -0400 [thread overview]
Message-ID: <20110330183446.GG1291@redhat.com> (raw)
In-Reply-To: <BANLkTimzt7QhBdayBpB3dRSOSY3G3VCfcw@mail.gmail.com>
On Wed, Mar 30, 2011 at 11:23:45AM -0700, Justin TerAvest wrote:
> On Fri, Mar 25, 2011 at 12:48 AM, Jens Axboe <jaxboe@fusionio.com> wrote:
> > On 2011-03-25 03:38, Justin TerAvest wrote:
> >> It's not clear why the cpu nice value should be mapped to the ioprio
> >> for a task when none is picked.
> >>
> >> Internally, at cfq_init_prio_data(), we just set:
> >> ioprio = IOPRIO_NORM;
> >> ioprio_class = IOPRIO_CLASS_BE;
> >> if ioprio_class is IOPRIO_CLASS_NONE.
> >>
> >>
> >> The problem is that today, SCHED_RR and SCHED_FIFO threads
> >> automatically get bumped up to RT class. This all happens behind the
> >> curtains and the io_class of the thread is still shown as NONE with
> >> sys_ioprio_get(). What's the motivation behind this promotion of
> >> ioprio class?
> >
> > It was decided back in the day when io priorities were introduced. I
> > still think it's a good idea.
>
> This is the part I'm especially curious about. If we're managing the
> resources separately,
> why should be be adjusting io_class based on the nice value?
What's wrong with taking a hint about ioclass and ioprio from cpu
scheduling class and nice value?
I think in general if some task is important from cpu perspective then
most likely it is important from IO perspective too. And if user thinks
otherwise, then one can explicitly set ioclass and ioprio of the task.
So this makes sense to me.
Thanks
Vivek
next prev parent reply other threads:[~2011-03-30 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 2:38 Why do we use cpu nice priority for ioprio? Justin TerAvest
2011-03-25 7:48 ` Jens Axboe
2011-03-30 18:23 ` Justin TerAvest
2011-03-30 18:34 ` Vivek Goyal [this message]
2011-03-31 3:59 ` Justin TerAvest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330183446.GG1291@redhat.com \
--to=vgoyal@redhat.com \
--cc=ctalbott@google.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox