public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Merge window closed - 2.6.39-rc1 out
Date: Wed, 30 Mar 2011 18:29:09 -0400	[thread overview]
Message-ID: <20110330222909.GA26174@infradead.org> (raw)
In-Reply-To: <20110330144359.GA16430@dumpdata.com>

 (1) it still has the totally stupid interface of a global dispatch table.
     Either it does make sense to have different providers, in which
     case you want the dispatch table on a per-superblock or whatever
     granularity, or you really want just one and can have static calls
     into it, and get rid of this whole layer
 (2) it still requires totally pointless calls from local filesystem to
     initialize a pool ID.  The filesystem really should not need to
     care about any of this.
 (3) it's still lacking a good user submitted with it.  And with that
     I don't mean junk code shoved into staging where it's bitrotting.

It also has an entirely new bug, in that it assumes every inode has
a dentry on the alias list.  Did you only ever test this with filesystem
that do not have export operations?  Otherwise the no-dentry case should
be fairly trivial to trigger due the placement of the hooks.

And of course there's still no convincing use case for all of this.


  parent reply	other threads:[~2011-03-30 22:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 21:07 Merge window closed - 2.6.39-rc1 out Linus Torvalds
2011-03-30 12:01 ` Christoph Hellwig
2011-03-30 14:43   ` Konrad Rzeszutek Wilk
2011-03-30 15:05     ` Konrad Rzeszutek Wilk
2011-03-30 22:29     ` Christoph Hellwig [this message]
2011-04-01 13:17       ` Konrad Rzeszutek Wilk
2011-03-30 22:20 ` [PATCH -rc1] msi-laptop: fix config-dependent build error Randy Dunlap
2011-03-31  6:41   ` Joey Lee
2011-04-01 18:21   ` Matthew Garrett
2011-03-31  2:17 ` Merge window closed - 2.6.39-rc1 out Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110330222909.GA26174@infradead.org \
    --to=hch@infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox