public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, trivial@kernel.org,
	lucas.de.marchi@gmail.com
Subject: Re: [GIT PULL] Fix common misspellings
Date: Thu, 31 Mar 2011 08:29:49 +0200	[thread overview]
Message-ID: <20110331062949.GA29526@elte.hu> (raw)
In-Reply-To: <20110331032307.GA27999@vigoh>


hi Lucas,

* Lucas De Marchi <lucas.demarchi@profusion.mobi> wrote:

> 
> Hi Linus,
> 
> Please pull the following fix for common misspellings in kernel code:
> 
> git://git.profusion.mobi/users/lucas/linux-2.6.git for-linus
> 
> I was doing it in a per maintainer basis, but as noted by Ingo, this was not
> working out.
> 
> There's only one big patch that fixes misspellings in
>  * Documentation
>  * Comments
>  * Strings that are used only in printk and the like

I've gone over your changes and noticed one very small thing, you've changed 
copyright strings as well:

- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007-2008 Marvell Internation Ltd.
+ * Copyright (C) 2007-2008 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (C) 2007 Marvell Internation Ltd.
+ * Copyright (C) 2007 Marvell International Ltd.
- * Copyright (c) 2002 The Regents of the Unviersity of Michigan
+ * Copyright (c) 2002 The Regents of the University of Michigan

While all the fixes are correct, i'd advise against changing copyright notices 
without the SOB of the authors. The s/Unviersity/University fix would be ok i 
guess because it's a very clear typo, but the Marvell one is borderline (while 
it too is probably a typo) i think it needs a signoff from those who put the 
copyright notices there in that form.

You could leave out those bits from the patch as well.

Thanks,

	Ingo

  reply	other threads:[~2011-03-31  6:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31  3:26 [GIT PULL] Fix common misspellings Lucas De Marchi
2011-03-31  6:29 ` Ingo Molnar [this message]
2011-03-31 13:52   ` Lucas De Marchi
2011-03-31 14:44   ` Lucas De Marchi
2011-04-06 14:17     ` Lucas De Marchi
2011-04-07 18:28       ` Linus Torvalds
2011-04-07 18:50         ` Ingo Molnar
2011-04-07 19:21           ` Lucas De Marchi
2011-04-07 19:24             ` Linus Torvalds
2011-04-07 19:05         ` Ingo Molnar
2011-04-07 19:07           ` Linus Torvalds
2011-04-07 19:19             ` Lucas De Marchi
2011-04-07 19:16         ` Lucas De Marchi
2011-04-07 19:19           ` Ingo Molnar
2011-04-07 19:23             ` Ingo Molnar
2011-04-07 19:24             ` Ingo Molnar
2011-04-07 19:31             ` Ingo Molnar
2011-04-07 19:47               ` Lucas De Marchi
  -- strict thread matches above, loose matches on Subject: below --
2011-05-29  6:07 Lucas De Marchi
2011-05-29 18:55 ` Linus Torvalds
2011-06-05 21:45   ` Jiri Kosina
2011-06-24 21:28   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331062949.GA29526@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.de.marchi@gmail.com \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox