The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, linux-pm@lists.linux-foundation.org,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ondrej Zary <linux@rainbow-software.org>
Subject: Re: [PATCH] x86 idle APM: delete apm_cpu_idle(), and its use of pm_idle
Date: Thu, 31 Mar 2011 08:56:22 +0200	[thread overview]
Message-ID: <20110331065622.GE5938@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.02.1103302311500.2444@x980>


* Len Brown <lenb@kernel.org> wrote:

> From: Len Brown <len.brown@intel.com>
> 
> There is some doubt whether the APM idle feature
> to call into the BIOS from the idle loop is reliable.
> Certainly it was known to fail on some machines,
> but more importantly, APM machines have not shipped
> for a decade and so finding machines to test the code
> is problematic.
> 
> After this patch, systems running in APM mode will
> simply run default_idle() and HALT without calling
> into the BIOS from their idle loop.
> 
> This deletes a much-maligned modular user of the (pm_idle)()
> function pointer.
> 
> Signed-off-by: Len Brown <len.brown@intel.com>

Ok, this should have far less negative impact on old hardware.

Acked-by: Ingo Molnar <mingo@elte.hu>

Thanks,

	Ingo

  reply	other threads:[~2011-03-31  6:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-26  6:22 [PATCH] apm: orphan the driver Stephen Rothwell
2011-03-28 12:44 ` Jiri Kosina
2011-03-28 13:44   ` Stephen Rothwell
2011-03-28 14:05     ` Jiri Kosina
2011-03-28 14:14       ` Joe Perches
2011-03-28 17:24         ` Jiri Kosina
2011-03-28 17:45       ` Andi Kleen
2011-03-28 17:57         ` H. Peter Anvin
2011-03-28 18:21           ` Andi Kleen
2011-03-28 18:24             ` H. Peter Anvin
2011-03-28 18:46             ` Linus Torvalds
2011-03-28 21:19               ` Jiri Kosina
2011-03-31  3:16                 ` [PATCH] x86 idle APM: delete apm_cpu_idle(), and its use of pm_idle Len Brown
2011-03-31  6:56                   ` Ingo Molnar [this message]
2011-04-01  9:28                   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331065622.GE5938@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hmh@hmh.eng.br \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux@rainbow-software.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox