public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"2nddept-manager@sdl.hitachi.co.jp" 
	<2nddept-manager@sdl.hitachi.co.jp>
Subject: Re: [RFC PATCH] perf report: add sort by file lines
Date: Thu, 31 Mar 2011 12:35:44 -0300	[thread overview]
Message-ID: <20110331153544.GC25095@ghostprotocols.net> (raw)
In-Reply-To: <1301581176.2271.9.camel@localhost>

Em Thu, Mar 31, 2011 at 10:19:36PM +0800, Lin Ming escreveu:
> On Thu, 2011-03-31 at 21:46 +0800, Arnaldo Carvalho de Melo wrote:
> > I think it does, so we do just like with annotation, but parsing objdump
> > -S output, is that what you're planning?
> 
> I mean to use libopcodes to decode the instructions.
> But to parse objdump -S output maybe a better and simpler idea.

When we started working on code annotation I thought about using a
library, but after a while, no, not really, better to parse a tool
output like Ingo did in the first usable version of perf annotate.

objdump output (and pahole, for data annotation) is very much set in
stone after all those years, so we can just use it.

> > After we have the members we can do data annotation, in much the same
> > way we do with code annotation, i.e. augmenting pahole output.
 
> What is data annotation? Is it to list the percentage of access for each
> member of the structure? For example,
 
> struct bar {
>         int poekoe[5];      //10%
>         int fubar;          //20%
> };

Exactly. Using different colors for percentage ranges, etc. Like code
annotation right now.

Done in perf report (static) zoomable, i.e. choosing a DSO and getting
the hits originated from functions in it, or in a thread, or in both,
like we have today for code annotation.

And in 'perf top --tui' live data annotation. With the same set of
zooming operations. So that one can see patterns of data structure
access as a workload runs.

- Arnaldo

  reply	other threads:[~2011-03-31 15:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  9:32 [RFC PATCH] perf report: add sort by file lines Lin Ming
2011-03-29  9:46 ` Masami Hiramatsu
2011-03-29  9:54 ` Peter Zijlstra
2011-03-29 16:45   ` Lin Ming
2011-03-29 17:03     ` Peter Zijlstra
2011-03-29 17:06       ` Peter Zijlstra
2011-03-29 17:08         ` Peter Zijlstra
2011-03-29 17:45           ` Arnaldo Carvalho de Melo
2011-03-30  1:04             ` Masami Hiramatsu
2011-03-30  2:18               ` Arnaldo Carvalho de Melo
2011-03-31  6:57               ` Lin Ming
2011-04-01 10:48                 ` Masami Hiramatsu
2011-03-31  8:45               ` Lin Ming
2011-03-31 13:46                 ` Arnaldo Carvalho de Melo
2011-03-31 14:19                   ` Lin Ming
2011-03-31 15:35                     ` Arnaldo Carvalho de Melo [this message]
2011-03-31 14:01                 ` Peter Zijlstra
2011-03-31 14:34                   ` Lin Ming
2011-03-31 14:51                     ` Lin Ming
2011-03-31 16:28                     ` Peter Zijlstra
2011-03-31 16:32                       ` Peter Zijlstra
2011-04-01 13:02                         ` Lin Ming
2011-04-01 13:48                           ` Peter Zijlstra
2011-04-01 10:44                       ` Masami Hiramatsu
2011-04-01 11:05                         ` Peter Zijlstra
2011-04-01 13:22                           ` Lin Ming
2011-04-01 13:49                             ` Peter Zijlstra
2011-04-01 13:57                               ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331153544.GC25095@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=2nddept-manager@sdl.hitachi.co.jp \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=ming.m.lin@intel.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox