public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	David Ahern <dsahern@gmail.com>,
	Akihiro Nagai <akihiro.nagai.hw@hitachi.com>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	2nddept-manager@sdl.hitachi.co.jp,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH -tip v3 3/6] perf branch trace: print pid and command
Date: Fri, 1 Apr 2011 12:24:31 -0300	[thread overview]
Message-ID: <20110401152431.GA26938@ghostprotocols.net> (raw)
In-Reply-To: <1301670917.4859.696.camel@twins>

Em Fri, Apr 01, 2011 at 05:15:17PM +0200, Peter Zijlstra escreveu:
> On Fri, 2011-04-01 at 17:13 +0200, Frederic Weisbecker wrote:
> > On Mon, Mar 28, 2011 at 08:31:23AM -0600, David Ahern wrote:
> > > On 03/28/11 04:34, Akihiro Nagai wrote:
> > > >> from is sample->ip? to is sample->addr? In the above example
> > > >> 0x39d3015260 is the value from sample->addr, 1526f is sample->ip which
> > > >> resolves to _dl_next_ld_env_entry from /lib64/ld-2.13.so.
> > > > Yes.
> > > > In this example, resolved address is only sample->ip (branch from).
> > > > We need the resolved address of sample->addr (branch to) too, because
> > > > both of them are addresses of execution code.
> > > 
> > > Ok, now I understand. In that case add conversion of sample->addr to
> > > symbols to perf-script.
> > 
> > I agree that we should rather use perf script for branch dumps.
> > Sorry Akihiro, I think we suggested you to create this dedicated
> > perf branch by the past. But then perf script became the vanilla dump
> > tool in the middle and it seems more suitable today.
> > 
> > We can still create a perf branch later in order to produce some more
> > advanced post-processing tools. But for sample dumps perf script (which starts
> > to show itself as a misnomer BTW) seems to be the right place.
> 
> Why do something with snakes if its perfectly possible to do in C ?

He is not meaning using python, hence the "misnomer" comment.

- Arnaldo

  reply	other threads:[~2011-04-01 15:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 11:31 [PATCH -tip v3 0/6] perf: Introduce branch sub commands Akihiro Nagai
2011-03-24 11:31 ` [PATCH -tip v3 1/6] perf: new subcommand perf branch record Akihiro Nagai
2011-03-24 11:32 ` [PATCH -tip v3 2/6] perf branch: Introduce new sub command 'perf branch trace' Akihiro Nagai
2011-03-24 11:32 ` [PATCH -tip v3 3/6] perf branch trace: print pid and command Akihiro Nagai
2011-03-24 17:05   ` David Ahern
2011-03-25 10:14     ` Akihiro Nagai
2011-03-25 15:02       ` David Ahern
2011-03-28 10:34         ` Akihiro Nagai
2011-03-28 14:31           ` David Ahern
2011-04-01 15:13             ` Frederic Weisbecker
2011-04-01 15:15               ` Peter Zijlstra
2011-04-01 15:24                 ` Arnaldo Carvalho de Melo [this message]
2011-04-01 17:11               ` David Ahern
2011-04-01 20:20                 ` Peter Zijlstra
2011-04-06 12:15                 ` Frederic Weisbecker
2011-04-06 14:09                   ` Arnaldo Carvalho de Melo
2011-04-06 14:15                     ` Peter Zijlstra
2011-04-06 14:30                       ` Frederic Weisbecker
2011-04-06 14:34                         ` David Ahern
2011-04-06 14:43                           ` Frederic Weisbecker
2011-04-06 14:42                       ` Frederic Weisbecker
2011-04-06 14:55                     ` Frederic Weisbecker
2011-04-06 17:18                       ` Arnaldo Carvalho de Melo
2011-04-04 10:00               ` Akihiro Nagai
2011-04-06 12:52                 ` Frederic Weisbecker
2011-04-11  4:54                   ` Akihiro Nagai
2011-03-24 11:32 ` [PATCH -tip v3 4/6] perf branch trace: print file path of the executed elf Akihiro Nagai
2011-03-24 11:32 ` [PATCH -tip v3 5/6] perf branch trace: print function+offset Akihiro Nagai
2011-03-24 11:32 ` [PATCH -tip v3 6/6] perf branch trace: add print all option Akihiro Nagai
2011-03-30 14:46 ` [PATCH -tip v3 0/6] perf: Introduce branch sub commands Frederic Weisbecker
2011-04-01 10:57   ` Akihiro Nagai
2011-04-01 12:51     ` Frederic Weisbecker
2011-04-01 14:43 ` Frederic Weisbecker
2011-04-04 10:06   ` Akihiro Nagai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110401152431.GA26938@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=2nddept-manager@sdl.hitachi.co.jp \
    --cc=akihiro.nagai.hw@hitachi.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox