From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Robert Rosengren <robert.rosengren@stericsson.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org,
Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] regulator: recursive locking detected
Date: Sat, 2 Apr 2011 10:12:03 +0900 [thread overview]
Message-ID: <20110402011202.GC25424@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301652257-19347-1-git-send-email-robert.rosengren@stericsson.com>
On Fri, Apr 01, 2011 at 12:04:17PM +0200, Robert Rosengren wrote:
> "possible recursive locking detected"-warnings are issued when a
> regulator has specified supply regulator. Both when enabling and
> disabling regulators uses recursive call chains for notify the supply
> regulators. This is due to locking mutexes of the same lock class,
> i.e. the locks reside in the regulator_dev struct.
There's actually a race here reported by David Brown in the past week
when working with supplies so the lock warning is probably a real issue
which should be fixed rather than overriding the warning. Search the
list for the past week or so for the details.
> +/* locks held by regulator_enable()
> + * lock_sublevel should always be 0, only used for recursive calls.
> + */
> +static int _regulator_enable(struct regulator_dev *rdev,
> + int lock_sublevel)
This comment is inaccurate (and if it were then obviously sublevel
wouldn't be needed).
next prev parent reply other threads:[~2011-04-02 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 10:04 [PATCH] regulator: recursive locking detected Robert Rosengren
2011-04-02 1:12 ` Mark Brown [this message]
2011-04-07 6:31 ` Robert ROSENGREN
-- strict thread matches above, loose matches on Subject: below --
2011-04-01 9:33 Robert Rosengren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110402011202.GC25424@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=robert.rosengren@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox