* [PATCH] USB:Fix the wrong function prototype .
@ 2011-04-04 10:29 wanlong.gao
2011-04-04 10:39 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: wanlong.gao @ 2011-04-04 10:29 UTC (permalink / raw)
To: gregkh, jhovold, alan, tsozik
Cc: linux-usb, linux-kernel, jiaweiwei.xiyou, Wanlong Gao
From: Wanlong Gao <wanlong.gao@gmail.com>
While the "mct_u232_device.ioctl" initialized by a wrong function
prototype . And the argument "struct file *file" is unused in
the function "mct_u232_ioctl()".
Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com>
---
drivers/usb/serial/mct_u232.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index d2c0196..ba0d287
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -106,7 +106,7 @@ static void mct_u232_break_ctl(struct tty_struct *tty, int break_state);
static int mct_u232_tiocmget(struct tty_struct *tty);
static int mct_u232_tiocmset(struct tty_struct *tty,
unsigned int set, unsigned int clear);
-static int mct_u232_ioctl(struct tty_struct *tty, struct file *file,
+static int mct_u232_ioctl(struct tty_struct *tty,
unsigned int cmd, unsigned long arg);
static int mct_u232_get_icount(struct tty_struct *tty,
struct serial_icounter_struct *icount);
@@ -874,7 +874,7 @@ static void mct_u232_unthrottle(struct tty_struct *tty)
}
}
-static int mct_u232_ioctl(struct tty_struct *tty, struct file *file,
+static int mct_u232_ioctl(struct tty_struct *tty,
unsigned int cmd, unsigned long arg)
{
DEFINE_WAIT(wait);
--
1.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] USB:Fix the wrong function prototype .
2011-04-04 10:29 [PATCH] USB:Fix the wrong function prototype wanlong.gao
@ 2011-04-04 10:39 ` Johan Hovold
2011-04-04 10:45 ` wanlong.gao
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2011-04-04 10:39 UTC (permalink / raw)
To: wanlong.gao
Cc: gregkh, alan, tsozik, linux-usb, linux-kernel, jiaweiwei.xiyou
On Mon, Apr 04, 2011 at 06:29:57PM +0800, wanlong.gao@gmail.com wrote:
> From: Wanlong Gao <wanlong.gao@gmail.com>
>
> While the "mct_u232_device.ioctl" initialized by a wrong function
> prototype . And the argument "struct file *file" is unused in
> the function "mct_u232_ioctl()".
Thanks for the patch, but I believe there was patch submitted last
Friday which also fixes this issue:
https://lkml.org/lkml/2011/4/3/74
Thanks,
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-04 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-04 10:29 [PATCH] USB:Fix the wrong function prototype wanlong.gao
2011-04-04 10:39 ` Johan Hovold
2011-04-04 10:45 ` wanlong.gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox