From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121Ab1DEHfI (ORCPT ); Tue, 5 Apr 2011 03:35:08 -0400 Received: from kroah.org ([198.145.64.141]:59378 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651Ab1DEHec (ORCPT ); Tue, 5 Apr 2011 03:34:32 -0400 Date: Mon, 4 Apr 2011 21:16:00 -0700 From: Greg KH To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Mike Sterling , Abhishek Kane Subject: Re: [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver Message-ID: <20110405041600.GA8090@kroah.com> References: <1300226527-26933-1-git-send-email-kys@microsoft.com> <1300226624-27004-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1300226624-27004-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2011 at 03:03:32PM -0700, K. Y. Srinivasan wrote: > Make vmbus driver a pci driver. This is > in preparation to cleaning up the root device > management as well as the irq allocation for this > driver. > > Signed-off-by: K. Y. Srinivasan > Signed-off-by: Haiyang Zhang > Signed-off-by: Mike Sterling > Signed-off-by: Abhishek Kane > Signed-off-by: Hank Janssen > --- > drivers/staging/hv/vmbus_drv.c | 63 +++++++++++++++++++++++----------------- > 1 files changed, 36 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > index b473f46..1ef2f0f 100644 > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -40,6 +40,8 @@ > #define VMBUS_IRQ 0x5 > #define VMBUS_IRQ_VECTOR IRQ5_VECTOR > > +struct pci_dev *hv_pci_dev; Why is this global? Have you forgot to run 'sparse' on your changes? thanks, greg k-h