public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ronald Kasl <rkasl@computer.org>
Cc: gregkh@suse.de, arun.thomas@gmail.com,
	darren.armstrong85@gmail.com, mithlesh@linsyssoft.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: comedi: fix coding style / spaces
Date: Mon, 4 Apr 2011 22:52:45 -0700	[thread overview]
Message-ID: <20110405055245.GA557@kroah.com> (raw)
In-Reply-To: <1284409861-3446-1-git-send-email-rkasl@computer.org>

On Mon, Sep 13, 2010 at 04:31:01PM -0400, Ronald Kasl wrote:
> This is a patch to the ssv_dnp.c file that fixes up the extra space warning
> found by the checkpatch.pl tool
> 
> Signed-off-by: Ronald Kasl <rkasl@computer.org>
> ---
>  drivers/staging/comedi/drivers/ssv_dnp.c |   40 +++++++++++++++---------------
>  1 files changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi/drivers/ssv_dnp.c
> index 526de2e..cb72436 100644
> --- a/drivers/staging/comedi/drivers/ssv_dnp.c
> +++ b/drivers/staging/comedi/drivers/ssv_dnp.c
> @@ -1,24 +1,24 @@
>  /*
> -    comedi/drivers/ssv_dnp.c
> -    generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
> -    Copyright (C) 2001 Robert Schwebel <robert@schwebel.de>
> -
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 2000 David A. Schleef <ds@schleef.org>
> -
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> -
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -
> -    You should have received a copy of the GNU General Public License
> -    along with this program; if not, write to the Free Software
> -    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> +comedi/drivers/ssv_dnp.c
> +generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
> +Copyright (C) 2001 Robert Schwebel <robert@schwebel.de>

Ick, no, don't indent like this, keep the leading spaces please.

This patch isn't needed at all :(

      reply	other threads:[~2011-04-05  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 20:31 [PATCH 1/1] Staging: comedi: fix coding style / spaces Ronald Kasl
2011-04-05  5:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110405055245.GA557@kroah.com \
    --to=greg@kroah.com \
    --cc=arun.thomas@gmail.com \
    --cc=darren.armstrong85@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mithlesh@linsyssoft.com \
    --cc=rkasl@computer.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox