From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: hjanssen@microsoft.com, kys@microsoft.com,
v-abkane@microsoft.com, gregkh@suse.de,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org, stable <stable@kernel.org>,
Mike Surcouf <mike@surcouf.co.uk>
Subject: Re: [PATCH] staging: hv: Fix GARP not sent after Quick Migration
Date: Tue, 5 Apr 2011 09:23:06 -0700 [thread overview]
Message-ID: <20110405162306.GA1800@kroah.com> (raw)
In-Reply-To: <1302020655-27133-1-git-send-email-haiyangz@microsoft.com>
On Tue, Apr 05, 2011 at 09:24:15AM -0700, Haiyang Zhang wrote:
> After Quick Migration, the network is not immediately operational in the
> current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put
> the netif_notify_peers() into a scheduled work, otherwise GARP packet will
> not be sent after quick migration, and cause network disconnection.
Wait, what are you relying on here for the delay? What happens when
processors get faster and that work queue gets run even sooner than
today? You are relying on the scheduler to introduce a "delay" here and
you can't rely on that at all.
Instead, use a proper timer as you do know how long you need to wait,
right? Don't abuse workqueues for something they were not designed for.
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-05 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 16:24 [PATCH] staging: hv: Fix GARP not sent after Quick Migration Haiyang Zhang
2011-04-05 16:23 ` Greg KH [this message]
2011-04-05 17:32 ` Haiyang Zhang
-- strict thread matches above, loose matches on Subject: below --
2011-04-06 22:18 Haiyang Zhang
2011-04-05 15:27 Haiyang Zhang
2011-04-05 15:41 ` Greg KH
2011-04-05 15:54 ` Haiyang Zhang
2011-04-05 16:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405162306.GA1800@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@surcouf.co.uk \
--cc=stable@kernel.org \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox