Re: [PATCH] Make all it87 drivers SMP safe.

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Tue, Apr 05, 2011 at 10:50:47PM -0400, Natarajan Gurumoorthy wrote:
> Guenter,
>       Thank you for spotting the fact the everything goes south if you
> disable "watchdog". I am working on a solution. Looks like the ideal
> place to store it87_io_lock.c will be drivers/misc and the IT87_LOCK
> config will be placed before the MISC_DEVICES entry in
> drivers/misc/Kconfig file. This will be similar to the
> SENSORS_LIS3LV02D entry in that Kconfig file.
> 
Almost, only afaik that is only used inside the misc directory, or at least
has some other components there. I don't really know how to handle this
situation correctly, except you could of course write a mfd driver to handle
the generic parts.

>       Now going back to the partitioning do I send this change out as
> a multi patch set consisting of 4 parts something as below:
> 
> patch 0 has a description
> 
> patch 1 has only the lock and related files
>         drivers/misc/Kconfig
>         drivers/misc/Makefile
>         include/linux/it87_lock.h
>         drivers/misc/it87_lock.c
> 
> patch 2 has drivers/watchdog changes
>         drivers/watchdog/Kconfig
>         drivers/watchdog/it8712f_wdt.c
>         drivers/watchdog/it87_wdt.c
> 
> patch 3 has drives/hwmon changes
>         drivers/hwmon/Kconfig
>         drivers/hwmon/it87.c
> 
Something like that. I have some doubts about using drivers/misc,
but I guess you'll get feedback on that after you submit the patch set.

Thanks,
Guenter