From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "achew@nvidia.com" <achew@nvidia.com>
Cc: "wni@nvidia.com" <wni@nvidia.com>,
"w30289@motorola.com" <w30289@motorola.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"olofj@chromium.org" <olofj@chromium.org>,
"toddpoynor@google.com" <toddpoynor@google.com>
Subject: Re: [lm-sensors] [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver
Date: Tue, 5 Apr 2011 23:50:48 -0700 [thread overview]
Message-ID: <20110406065048.GA23290@ericsson.com> (raw)
In-Reply-To: <20110406050929.GA22741@ericsson.com>
On Wed, Apr 06, 2011 at 01:09:29AM -0400, Guenter Roeck wrote:
> On Tue, Apr 05, 2011 at 11:06:23PM -0400, achew@nvidia.com wrote:
> > From: Andrew Chew <achew@nvidia.com>
> >
> > This is a digital temperature sensor I2C peripheral from ON Semiconductor.
> >
> > Signed-off-by: Andrew Chew <achew@nvidia.com>
>
> Comments inline. Note that this is not a complete review.
>
Actually, turns out it would be much simpler to add support for this chip
to the lm90 driver. It is pretty much identical to ADT7461. Even more
interesting is that the chip ID is identical to the ADT7461A chip ID.
Guenter
next prev parent reply other threads:[~2011-04-06 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 3:06 [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver achew
2011-04-06 5:09 ` Guenter Roeck
2011-04-06 6:50 ` Guenter Roeck [this message]
2011-04-06 8:01 ` [lm-sensors] " Jean Delvare
2011-04-06 7:23 ` Jean Delvare
2011-04-06 7:32 ` Guenter Roeck
2011-04-06 8:15 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406065048.GA23290@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=achew@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=olofj@chromium.org \
--cc=toddpoynor@google.com \
--cc=w30289@motorola.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox