The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Jason Baron <jbaron@redhat.com>
Cc: Joe Perches <joe@perches.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Roland Vossen <rvossen@broadcom.com>,
	devel <devel@linuxdriverproject.org>
Subject: Re: [Fwd: Fwd: Re: Why is dynamic debug disabled for staging drivers ?]
Date: Wed, 6 Apr 2011 11:55:25 -0700	[thread overview]
Message-ID: <20110406185525.GA12915@suse.de> (raw)
In-Reply-To: <20110406184158.GA6981@redhat.com>

On Wed, Apr 06, 2011 at 02:41:59PM -0400, Jason Baron wrote:
> The concern I would have in allowing tainted modules is that we are
> relying on a specific format for the dynamic debug section in the
> compiled module. For example, if a module was built with a format with an old
> section, we could potentially get confused. This can be solved with
> versioning, but that adds extra complexity. We can of course also make
> sure we don't change the format...

I wouldn't worry about that at all.  If you try to load a kernel module
that was not built against the kernel you are running, all bets are off
and lots of bad things can happen in other areas.

> Notice that tracepoints, which also rely on a specific module format,
> also employ a taint flag check.

Ok, but TAINT_CRAP shouldn't be part of that check, right?

thanks,

greg k-h

  reply	other threads:[~2011-04-06 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 15:34 [Fwd: Fwd: Re: Why is dynamic debug disabled for staging drivers ?] Joe Perches
2011-04-06 18:41 ` Jason Baron
2011-04-06 18:55   ` Greg KH [this message]
2011-04-06 19:16     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406185525.GA12915@suse.de \
    --to=gregkh@suse.de \
    --cc=devel@linuxdriverproject.org \
    --cc=jbaron@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rvossen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox