From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steve Rago <sar@nec-labs.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Allow O_SYNC to be set by fcntl(F_SETFL)
Date: Fri, 8 Apr 2011 11:14:55 -0400 [thread overview]
Message-ID: <20110408151454.GA1444@infradead.org> (raw)
In-Reply-To: <20110407143719.4044c00d.akpm@linux-foundation.org>
I actually prototypes this patch independetly a while ago, and in
addition to the data writeout when removing O_SYNC there are the
following caveats:
- O_SYNC is not actually one flag, but two: O_DSYNC and __O_SYNC.
setfl() needs to make sure __O_SYNC cannot be in f_flags without
O_DSYNC also beeing present.
- we need to audit all filesystems that they don't do stupid things
when the O_SYNC flags appear or disappear during a write, that
is make sure it is checked in just one place. The generic write
code is fine in that respect, but I didn't go through all filesystems
to verify it yet.
next prev parent reply other threads:[~2011-04-08 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 21:52 [PATCH] Allow O_SYNC to be set by fcntl(F_SETFL) Steve Rago
2011-04-07 21:37 ` Andrew Morton
2011-04-08 15:14 ` Christoph Hellwig [this message]
2011-04-08 17:39 ` Steve Rago
2011-04-08 17:56 ` Andrew Morton
2011-04-08 21:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408151454.GA1444@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sar@nec-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox