public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Feng Tang <feng.tang@intel.com>, Alan Cox <alan@linux.intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] x86/mrst: correct pin to irq mapping
Date: Fri, 8 Apr 2011 17:45:40 +0200	[thread overview]
Message-ID: <20110408154540.GC17934@elte.hu> (raw)
In-Reply-To: <1302201172-1254-1-git-send-email-jacob.jun.pan@linux.intel.com>


* Jacob Pan <jacob.jun.pan@linux.intel.com> wrote:

> Set mp_bus_not_pci bit to allow 1:1 mapping of pin2irq on Moorestown.
> Refer to discussion in:
> https://lkml.org/lkml/2010/6/10/70
> 
> Suggested-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  arch/x86/platform/mrst/mrst.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Could you please improve the changelog to explain to the reader:

 - why has this change been done
 - what are the effects on users (if any)
 - what is the urgency of the patch (needed for .39, or can wait for .40)

lkml.org links may or may not work in the future, we really need proper 
background information in changelogs.

Thanks,

	Ingo

  reply	other threads:[~2011-04-08 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 18:32 [PATCH] x86/mrst: correct pin to irq mapping Jacob Pan
2011-04-08 15:45 ` Ingo Molnar [this message]
2011-04-08 18:24   ` jacob pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110408154540.GC17934@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=ebiederm@xmission.com \
    --cc=feng.tang@intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox