From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: Don't schedule tracepoints when exclude_kernel is set
Date: Sat, 9 Apr 2011 15:27:14 +0200 [thread overview]
Message-ID: <20110409132709.GA1799@nowhere> (raw)
In-Reply-To: <1302354884.9086.1272.camel@twins>
On Sat, Apr 09, 2011 at 03:14:44PM +0200, Peter Zijlstra wrote:
> On Fri, 2011-04-08 at 22:57 +0200, Frederic Weisbecker wrote:
> > Instead of checking attr.exclude_kernel anytime a tracepoint
> > event triggers, simply don't schedule the tracepoint it that
> > attribute is set. This makes one test less in the tracing
> > path.
>
> Meh, I'd much rather someone spend some time on finishing the below,
> which is a much bigger improvement for trace-events.
I secretely added that to my pile already :)
That's indeed something we really want.
The above is just a little thing I noticed yesterday and I wanted
to fix. Nothing more.
About that tracepoint collection, I'm not sure I like the idr though.
That thing seems to be O(log(n)), I which we can rather approach O(1)
when possible, using a hlist perhaps.
next prev parent reply other threads:[~2011-04-09 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 20:57 [PATCH] perf: Don't schedule tracepoints when exclude_kernel is set Frederic Weisbecker
2011-04-09 13:14 ` Peter Zijlstra
2011-04-09 13:17 ` Ingo Molnar
2011-04-09 13:27 ` Frederic Weisbecker [this message]
2011-04-09 13:37 ` Peter Zijlstra
2011-04-12 15:48 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110409132709.GA1799@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox