* lockdep splat: nfsroot on 2.6.39-rc2
@ 2011-04-10 2:55 Will Simoneau
2011-04-11 4:02 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Will Simoneau @ 2011-04-10 2:55 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 5242 bytes --]
Hi,
I just got this soft-lockup 3 times in a row and was able to reproduce
it with lockdep enabled. The kernel is Linus git 94c8a984 plus patches
to support my hardware. System is a full custom 2-way SMP mipsel/R4K
clone on an FPGA, I am hoping this is not my fault or the hardware's
fault though. Root is on NFS (tcp).
This seems to happen consistently when running "apt-get update". Ideas?
Known bug?
---8<---
[ 926.390000] =============================================
[ 926.390000] [ INFO: possible recursive locking detected ]
[ 926.390000] 2.6.39-rc2+ #7
[ 926.390000] ---------------------------------------------
[ 926.390000] rred/1443 is trying to acquire lock:
[ 926.390000] (&sb->s_type->i_lock_key#11){+.+.-.}, at: [<800dc6c0>] __mark_in
ode_dirty+0x70/0x250
[ 926.390000]
[ 926.390000] but task is already holding lock:
[ 926.390000] (&sb->s_type->i_lock_key#11){+.+.-.}, at: [<8017b128>] nfs_commi
t_inode+0xe8/0x270
[ 926.390000]
[ 926.390000] other info that might help us debug this:
[ 926.390000] 3 locks held by rred/1443:
[ 926.390000] #0: (&sb->s_type->i_mutex_key#3){+.+.+.}, at: [<8007a3f0>] gene
ric_file_aio_write+0x6c/0x120
[ 926.390000] #1: (&type->s_umount_key#14){++++..}, at: [<800dcb94>] writebac
k_inodes_wb+0xb8/0x178
[ 926.390000] #2: (&sb->s_type->i_lock_key#11){+.+.-.}, at: [<8017b128>] nfs_
commit_inode+0xe8/0x270
[ 926.390000]
[ 926.390000] stack backtrace:
[ 926.390000] Call Trace:
[ 926.390000] [<8032666c>] dump_stack+0x8/0x34
[ 926.390000] [<80065eb8>] __lock_acquire+0x1454/0x1d44
[ 926.390000] [<8006681c>] lock_acquire+0x74/0xb0
[ 926.390000] [<8032a898>] _raw_spin_lock+0x40/0x54
[ 926.390000] [<800dc6c0>] __mark_inode_dirty+0x70/0x250
[ 926.390000] [<8017b268>] nfs_commit_inode+0x228/0x270
[ 926.390000] [<8017bc50>] nfs_write_inode+0x74/0xcc
[ 926.390000] [<800db9b0>] writeback_single_inode+0x298/0x2a0
[ 926.390000] [<800dbf40>] writeback_sb_inodes+0x11c/0x1f0
[ 926.390000] [<800dcbbc>] writeback_inodes_wb+0xe0/0x178
[ 926.390000] [<80083a3c>] balance_dirty_pages_ratelimited_nr+0x4f8/0x644
[ 926.390000] [<80077b7c>] generic_file_buffered_write+0x16c/0x2f0
[ 926.390000] [<8007a018>] __generic_file_aio_write+0x28c/0x5f8
[ 926.390000] [<8007a40c>] generic_file_aio_write+0x88/0x120
[ 926.390000] [<8016b1a4>] nfs_file_write+0x104/0x29c
[ 926.390000] [<800b1c30>] do_sync_readv_writev+0xbc/0x13c
[ 926.390000] [<800b2520>] do_readv_writev+0xbc/0x1c8
[ 926.390000] [<800b268c>] vfs_writev+0x60/0x78
[ 926.390000] [<800b27ac>] sys_writev+0x50/0xa0
[ 926.390000] [<8000afd8>] stack_done+0x20/0x40
[ 926.390000]
[ 989.240000] BUG: soft lockup - CPU#0 stuck for 61s! [rred:1443]
[ 989.240000] irq event stamp: 995027
[ 989.240000] hardirqs last enabled at (995027): [<8032b538>] _raw_spin_unlock
_irqrestore+0x9c/0xd8
[ 989.240000] hardirqs last disabled at (995026): [<8032aa08>] _raw_spin_lock_i
rqsave+0x40/0x90
[ 989.240000] softirqs last enabled at (995006): [<80033d1c>] do_softirq+0xfc/
0x104
[ 989.240000] softirqs last disabled at (994993): [<80033d1c>] do_softirq+0xfc/
0x104
[ 989.240000] Cpu 0
[ 989.240000] $ 0 : 00000000 10008c00 85e285e1 000085e2
[ 989.240000] $ 4 : 00000000 015bf440 8002c7a8 00000000
[ 989.240000] $ 8 : 00000000 00000001 ffffffff 00000000
[ 989.240000] $12 : a3f77b00 83d7c140 00000000 00000003
[ 989.240000] $16 : 8383cb94 00010000 00000000 02703800
[ 989.240000] $20 : 803aaf6c 00000001 015bf440 00000000
[ 989.240000] $24 : 00000000 00000000
[ 989.240000] $28 : 827f2000 827f39e8 8383cb34 801ba4b4
[ 989.240000] Hi : 00000000
[ 989.240000] Lo : 00002f00
[ 989.240000] epc : 801ba48c do_raw_spin_lock+0x12c/0x1cc
[ 989.240000] Not tainted
[ 989.240000] ra : 801ba4b4 do_raw_spin_lock+0x154/0x1cc
[ 989.240000] Status: 10008c03 KERNEL EXL IE
[ 989.240000] Cause : 00008000
[ 989.240000] PrId : 00004800 (Z4800)
[ 992.830000] BUG: soft lockup - CPU#1 stuck for 63s! [kworker/1:1:213]
[ 992.900000] irq event stamp: 499011
[ 992.970000] hardirqs last enabled at (499011): [<801791d8>] nfs_mark_request
_commit+0x14c/0x200
[ 993.050000] hardirqs last disabled at (499010): [<8017913c>] nfs_mark_request
_commit+0xb0/0x200
[ 993.120000] softirqs last enabled at (498916): [<80033d1c>] do_softirq+0xfc/
0x104
[ 993.200000] softirqs last disabled at (498911): [<80033d1c>] do_softirq+0xfc/
0x104
[ 993.270000] Cpu 1
[ 993.340000] $ 0 : 00000000 10008800 85e285e1 000085e2
[ 993.410000] $ 4 : 00000000 021056b6 807e8c2c 00000000
[ 993.480000] $ 8 : 807e8c2c 0000012e 00000000 fff80003
[ 993.560000] $12 : 00000001 00000008 4e0811a1 13aebc2e
[ 993.630000] $16 : 8383cb94 00010000 00000000 02703800
[ 993.700000] $20 : 803aaf6c 00000001 021056b6 00000000
[ 993.780000] $24 : 00000000 80002be0
[ 993.850000] $28 : 83cb0000 83cb1d68 803a7458 801ba4b4
[ 993.920000] Hi : 0f388e26
[ 993.990000] Lo : fed1e12d
[ 994.050000] epc : 801ba48c do_raw_spin_lock+0x12c/0x1cc
[ 994.130000] Not tainted
[ 994.190000] ra : 801ba4b4 do_raw_spin_lock+0x154/0x1cc
[ 994.270000] Status: 10008803 KERNEL EXL IE
[ 994.340000] Cause : 00008000
[ 994.400000] PrId : 00004800 (Z4800)
---8<---
Thanks for looking.
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: lockdep splat: nfsroot on 2.6.39-rc2
2011-04-10 2:55 lockdep splat: nfsroot on 2.6.39-rc2 Will Simoneau
@ 2011-04-11 4:02 ` Dave Chinner
2011-04-11 7:23 ` Will Simoneau
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2011-04-11 4:02 UTC (permalink / raw)
To: Will Simoneau; +Cc: linux-kernel, linux-nfs
On Sat, Apr 09, 2011 at 10:55:02PM -0400, Will Simoneau wrote:
> Hi,
>
> I just got this soft-lockup 3 times in a row and was able to reproduce
> it with lockdep enabled. The kernel is Linus git 94c8a984 plus patches
> to support my hardware. System is a full custom 2-way SMP mipsel/R4K
> clone on an FPGA, I am hoping this is not my fault or the hardware's
> fault though. Root is on NFS (tcp).
>
> This seems to happen consistently when running "apt-get update". Ideas?
> Known bug?
The bug is in nfs_commit_inode(), where it calls nfs_scan_commit()
with the inode->i_lock held and that calls __mark_inode_dirty()
which takes the inode->i_lock....
The patch below should fix this problem.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
nfs: don't call __mark_inode_dirty while holding i_lock
From: Dave Chinner <dchinner@redhat.com>
nfs_scan_commit() is called with the inode->i_lock held, but it then calls
__mark_inode_dirty() while still holding the lock. This causes a deadlock.
Move the __mark_inode_dirty() call outside nfs_scan_commit() and the
inode->i_lock to avoid the deadlock.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/nfs/write.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index af0c627..e4cbc11 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -542,11 +542,15 @@ nfs_scan_commit(struct inode *inode, struct list_head *dst, pgoff_t idx_start, u
if (!nfs_need_commit(nfsi))
return 0;
+ spin_lock(&inode->i_lock);
ret = nfs_scan_list(nfsi, dst, idx_start, npages, NFS_PAGE_TAG_COMMIT);
if (ret > 0)
nfsi->ncommit -= ret;
+ spin_unlock(&inode->i_lock);
+
if (nfs_need_commit(NFS_I(inode)))
__mark_inode_dirty(inode, I_DIRTY_DATASYNC);
+
return ret;
}
#else
@@ -1483,9 +1487,7 @@ int nfs_commit_inode(struct inode *inode, int how)
res = nfs_commit_set_lock(NFS_I(inode), may_wait);
if (res <= 0)
goto out_mark_dirty;
- spin_lock(&inode->i_lock);
res = nfs_scan_commit(inode, &head, 0, 0);
- spin_unlock(&inode->i_lock);
if (res) {
int error;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: lockdep splat: nfsroot on 2.6.39-rc2
2011-04-11 4:02 ` Dave Chinner
@ 2011-04-11 7:23 ` Will Simoneau
0 siblings, 0 replies; 3+ messages in thread
From: Will Simoneau @ 2011-04-11 7:23 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-kernel, linux-nfs
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
On 14:02 Mon 11 Apr , Dave Chinner wrote:
> On Sat, Apr 09, 2011 at 10:55:02PM -0400, Will Simoneau wrote:
> > This seems to happen consistently when running "apt-get update". Ideas?
> > Known bug?
>
> The bug is in nfs_commit_inode(), where it calls nfs_scan_commit()
> with the inode->i_lock held and that calls __mark_inode_dirty()
> which takes the inode->i_lock....
>
> The patch below should fix this problem.
I can confirm that your patch fixes the issue. Thanks for the fix!
Tested-by: Will Simoneau <simoneau@ele.uri.edu>
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-11 7:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-10 2:55 lockdep splat: nfsroot on 2.6.39-rc2 Will Simoneau
2011-04-11 4:02 ` Dave Chinner
2011-04-11 7:23 ` Will Simoneau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox