Re: [RFC]Documentation:accounting:getdelays.c Fix: warning: variable ‘i’ set but not used

[Randy Dunlap <rdunlap@xenotime.net>]

On Tue,  5 Apr 2011 09:02:50 -0700 Justin P. Mattock wrote:

> The below patch takes care of the warning, but keep in mind am unsure if this is a correct way
> to resolve this issue.
> Documentation/accounting/getdelays.c: In function ‘main’:
> Documentation/accounting/getdelays.c:436:7: warning: variable ‘i’ set but not used [-Wunused-but-set-variable]
> 
> Keep in mind there is another warning with this file, but need am unsure what might be the best solution:
> Documentation/accounting/getdelays.c: In function ‘get_family_id’:
> Documentation/accounting/getdelays.c:172:14: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]

Hi,
Does -Wunused-but-set-variable require gcc 4.6.0?


>  Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> 
> ---
>  Documentation/accounting/getdelays.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index e9c7778..16e16d5 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -433,8 +433,6 @@ int main(int argc, char *argv[])
>  	}
>  
>  	do {
> -		int i;
> -
>  		rep_len = recv(nl_sd, &msg, sizeof(msg), 0);
>  		PRINTF("received %d bytes\n", rep_len);
>  
> @@ -459,7 +457,6 @@ int main(int argc, char *argv[])
>  
>  		na = (struct nlattr *) GENLMSG_DATA(&msg);
>  		len = 0;
> -		i = 0;
>  		while (len < rep_len) {
>  			len += NLA_ALIGN(na->nla_len);
>  			switch (na->nla_type) {
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***